Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis to test on Laravel 5.6 to 6.x #225

Closed
wants to merge 9 commits into from

Conversation

avvertix
Copy link
Contributor

@avvertix avvertix commented Apr 7, 2020

Looking at #222 I was questioning myself if everything is compatible with latest PHP and Laravel versions.

The main goal of this pull request is to ensure that automated tests on Travis CI can be executed for all the supported Laravel and PHP versions, so I did the following changes:

  • Make PHP 7.0 the minimum PHP version
  • Update composer.json to ensure a Laravel package is specified to mark the version under testing
  • Update composer.json to ensure that the dev dependencies can be resolved to an installable set of packages for the supported PHP and Laravel version
  • Update unit tests to remove deprecation notices

@avvertix avvertix changed the title Update Travis to test on Laravel 5.5 to 6.x Update Travis to test on Laravel 5.6 to 6.x Apr 7, 2020
@franzose
Copy link
Owner

franzose commented Apr 7, 2020

Hello, @avvertix! Thank you for your work. But I'm afraid it's going to conflict with the changes I have already made in another branch. Currently I'm working on ClosureTable 6.0, it'll have a lot of bugfixes and improvements, but still 5.6 compatible.

@franzose
Copy link
Owner

franzose commented Apr 7, 2020

I think I'll try to incorporate some of your work into mine. Thank you and sorry for the inconvenience.

@avvertix
Copy link
Contributor Author

avvertix commented Apr 7, 2020

Oh I didn't see the other branch, otherwise I might have started from it.

Feel free to grab what you need from this pull request.

@franzose
Copy link
Owner

franzose commented Apr 7, 2020

Oh I didn't see the other branch, otherwise I might have started from it.

This is because I haven't pushed it yet.

@franzose
Copy link
Owner

franzose commented Apr 9, 2020

Hi, @avvertix! I really need your work on Travis CI configuration. Please, take a look at 6.x branch. It's a new branch in which I'm working on a new release. I'd highly appreciate your new PR into that branch.

Notice that ClosureTable 6 must support Laravel 5.4+ and PHP 5.6+ to provide maximum smoothness for the existing users during upgrade (I hope they exist 😀). I have already tested it manually on 5.4, 5.5 and 5.6. But, of course, we need an automatic way to check that.

Ensure to include Laravel 5.4-5.6, PHP 5.6-7.2 and PostgreSQL into Travis CI configuration file, okay?

@avvertix
Copy link
Contributor Author

Ok I'll try to rebase on that branch and get it to work for Laravel 5.4 to 5.6.

@franzose
Copy link
Owner

franzose commented Apr 16, 2020

@avvertix thank you, keep in mind that the only file needed is .travis.yaml. This is because I have already done a lot of work in many files, it's unlikely we can merge all that properly without backwards compatibility break.

@avvertix
Copy link
Contributor Author

Sure, I will grab the 6.x branch and open a new pull request to keep it as clean as possible.

@avvertix avvertix mentioned this pull request Apr 16, 2020
@franzose
Copy link
Owner

Closing in favour of #226

@franzose franzose closed this Apr 17, 2020
@avvertix avvertix deleted the test-laravel-5.7-5.8-6.x branch April 17, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants