New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Travis to test on Laravel 5.6 to 6.x #225
Conversation
Hello, @avvertix! Thank you for your work. But I'm afraid it's going to conflict with the changes I have already made in another branch. Currently I'm working on ClosureTable 6.0, it'll have a lot of bugfixes and improvements, but still 5.6 compatible. |
I think I'll try to incorporate some of your work into mine. Thank you and sorry for the inconvenience. |
Oh I didn't see the other branch, otherwise I might have started from it. Feel free to grab what you need from this pull request. |
This is because I haven't pushed it yet. |
Hi, @avvertix! I really need your work on Travis CI configuration. Please, take a look at 6.x branch. It's a new branch in which I'm working on a new release. I'd highly appreciate your new PR into that branch. Notice that ClosureTable 6 must support Laravel 5.4+ and PHP 5.6+ to provide maximum smoothness for the existing users during upgrade (I hope they exist 😀). I have already tested it manually on 5.4, 5.5 and 5.6. But, of course, we need an automatic way to check that. Ensure to include Laravel 5.4-5.6, PHP 5.6-7.2 and PostgreSQL into Travis CI configuration file, okay? |
Ok I'll try to rebase on that branch and get it to work for Laravel 5.4 to 5.6. |
@avvertix thank you, keep in mind that the only file needed is .travis.yaml. This is because I have already done a lot of work in many files, it's unlikely we can merge all that properly without backwards compatibility break. |
Sure, I will grab the 6.x branch and open a new pull request to keep it as clean as possible. |
Closing in favour of #226 |
Looking at #222 I was questioning myself if everything is compatible with latest PHP and Laravel versions.
The main goal of this pull request is to ensure that automated tests on Travis CI can be executed for all the supported Laravel and PHP versions, so I did the following changes: