Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test using Travis CI #226

Merged
merged 19 commits into from Apr 17, 2020
Merged

Test using Travis CI #226

merged 19 commits into from Apr 17, 2020

Conversation

avvertix
Copy link
Contributor

This is a current work in progress to replace #225 in order to

  • Test on PHP 5.6 to 7.4
  • Test using Laravel 5.4 to 7.x
  • Apply the minimal changes as possible

@avvertix
Test using Travis CI
8fb0517 
Link mysql service

Making sense of the matrix configuration

Update
@avvertix
Travis CI
1c32637
@avvertix
branch
df099da
franzose
franzose requested changes Apr 16, 2020
View reviewed changes
.travis.yml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
avvertix
avvertix commented Apr 16, 2020
View reviewed changes
composer.json Outdated Show resolved Hide resolved
franzose
franzose reviewed Apr 16, 2020
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@avvertix
Copy link
Contributor Author

avvertix commented Apr 16, 2020 •
edited

Now all tests on MySQL are running. Seems that Laravel 5.4 on PHP 5.6 fails because a test case failure

1) Franzose\ClosureTable\Tests\Models\Entity\ConstructionTests::testCreate
BadMethodCallException: Call to undefined method Illuminate\Database\Query\Builder::getLatestPosition()

@avvertix avvertix marked this pull request as ready for review April 16, 2020 18:17
@franzose franzose marked this pull request as ready for review April 17, 2020 03:04
@franzose franzose mentioned this pull request Apr 17, 2020
Closed
franzose
franzose approved these changes Apr 17, 2020
View reviewed changes
Copy link
Owner

@franzose franzose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems everything's good. We can add PostgreSQL to Travis later, after I have resolved the issue with tests on the Laravel 5.4.

@franzose franzose merged commit c745f9f into franzose:6.x Apr 17, 2020
@avvertix avvertix deleted the travis-ci-for-6.x branch April 18, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franzose franzose franzose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@avvertix @franzose