Declaration of Franzose\ClosureTable\Entity::performUpdate() should be compatible

[ben-joostens]

All of a sudden I'm getting this error…

Declaration of Franzose\ClosureTable\Entity::performUpdate() should be compatible with Illuminate\Database\Eloquent\Model::performUpdate(Illuminate\Database\Eloquent\Builder $query)

The declaration in Entity looks like this:
protected function performUpdate($query)

And in core:
protected function performUpdate(Builder $query)

[ben-joostens]

Just fyi, it complains about both performUpdate and performInsert

[ben-joostens]

Seems to be ok again after importing builder in Entitiy.php:

use \Illuminate\Database\Eloquent\Builder;

and Updating both declarations:

protected function performInsert(Builder $query)
protected function performUpdate(Builder $query)

[franzose]

@ben-joostens, It's strange but I have no such messages as you have... Would you like to make the pull request with these changes? Otherwise I can do it myself.

[ben-joostens]

@franzose Alright, pull request made.

[franzose]

@ben-joostens, thank you man! Please, however, make all your further pulls to 2.0 branch.

[vjandrea]

I continue to see these messages in my php error log:
[09-Oct-2013 23:24:44 Europe/Berlin] PHP Strict Standards: Declaration of Franzose\ClosureTable\Entity::performInsert() should be compatible with Illuminate\Database\Eloquent\Model::performInsert(Illuminate\Database\Eloquent\Builder $query) in /Users/macbookpro/Documents/Github/closure_features/ClosureTable/src/models/Entity.php on line 0
I'm in sync with branch 2.0 so i don't know why it doesn't work.

[franzose]

Even with performInsert and performUpdate having Builder $query as the parameter?..

[vjandrea]

Yes, that's bizarre. Anyway, i cloned again and the problem doesn't appear anymore, so probably it was a git cache issue.