Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

declaration error #50

Closed
gchabb opened this issue Oct 7, 2013 · 5 comments
Closed

declaration error #50

gchabb opened this issue Oct 7, 2013 · 5 comments

Comments

@gchabb
Copy link

gchabb commented Oct 7, 2013

I Have just update with composer, i have this message :

Declaration of Franzose\ClosureTable\Entity::performUpdate() should be compatible with that of Illuminate\Database\Eloquent\Model::performUpdate()

@Riaan-ZA
Copy link

Riaan-ZA commented Oct 7, 2013

I can confirm, getting the same error after upgrading

@ben-joostens
Copy link
Contributor

Yeah this is weird because I had pushed a fix for this, but apparently that fix isn't completely merged.

You need to change the declaration for performInsert and performUpdate in Entity.php to (Builder $query)

Sorry for the less than verbose explanation, I'm on my mobile.

@Riaan-ZA
Copy link

Riaan-ZA commented Oct 7, 2013

Thanks,

more info here: #39

franzose added a commit that referenced this issue Oct 7, 2013
fixed #50, somehow accidentially erased updates of @ben-joostens
@franzose
Copy link
Owner

franzose commented Oct 7, 2013

I'm sorry, colleagues, it seems I erased the changes of @ben-joostens accidentially while solving another problems. Now fixed. Please update your packages.

@gchabb
Copy link
Author

gchabb commented Oct 7, 2013

it works thanks !

2013/10/7 Jan Iwanow notifications@github.com

I'm sorry, colleagues, it seems I erased the changes of @ben-joostenshttps://github.com/ben-joostensaccidentially while solving another problems. Now fixed. Please update your
packages.


Reply to this email directly or view it on GitHubhttps://github.com//issues/50#issuecomment-25803725
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants