-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix easy-install.py test #1408
Conversation
patched bench removed and frappe-bench installed --no-mariadb-socket required for new-site
to test before the linked PR is merged change following urllib.request.urlretrieve(
"https://github.com/frappe/frappe_docker/archive/refs/heads/main.zip",
"frappe_docker.zip",
)
# ...
move("frappe_docker-main", "frappe_docker") will change to urllib.request.urlretrieve(
"https://github.com/revant/frappe_docker/archive/refs/heads/refactor-single-image.zip",
"frappe_docker.zip",
)
# ...
move("frappe_docker-refactor-single-image", "frappe_docker") |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @revant for the quick fixes :)
🎉 This PR is included in version 5.16.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
related to frappe/frappe_docker#1032