Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix easy-install.py test #1408

Merged
merged 5 commits into from
Jan 16, 2023
Merged

Conversation

revant
Copy link
Collaborator

@revant revant commented Dec 28, 2022

@revant revant marked this pull request as draft December 28, 2022 14:09
patched bench removed and frappe-bench installed
--no-mariadb-socket required for new-site
@revant
Copy link
Collaborator Author

revant commented Dec 28, 2022

to test before the linked PR is merged change following

		urllib.request.urlretrieve(
			"https://github.com/frappe/frappe_docker/archive/refs/heads/main.zip",
			"frappe_docker.zip",
		)
                # ...
		move("frappe_docker-main", "frappe_docker")

will change to

		urllib.request.urlretrieve(
			"https://github.com/revant/frappe_docker/archive/refs/heads/refactor-single-image.zip",
			"frappe_docker.zip",
		)
                # ...
		move("frappe_docker-refactor-single-image", "frappe_docker")

@ankush ankush requested a review from athul January 2, 2023 10:31
@revant revant marked this pull request as ready for review January 16, 2023 07:05
@sonarcloud
Copy link

sonarcloud bot commented Jan 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

Copy link
Contributor

@athul athul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @revant for the quick fixes :)

@athul
Copy link
Contributor

athul commented Jan 16, 2023

@ankush We could merge this. Tested out locally and it works. Will also close #1416

@ankush ankush merged commit b3ad10b into frappe:develop Jan 16, 2023
@github-actions
Copy link

🎉 This PR is included in version 5.16.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants