Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: accounting for taxes on payments #755

Closed
mildred opened this issue Oct 11, 2023 · 0 comments · Fixed by #789
Closed

feature: accounting for taxes on payments #755

mildred opened this issue Oct 11, 2023 · 0 comments · Fixed by #789
Assignees
@mildred
Labels
enhancement New feature or request

Comments

@mildred
Copy link
Contributor

mildred commented Oct 11, 2023

In France, in some circumstances, tax are due not on invoicing but when the invoice is paid.

When the invoice is submitted, the following transaction shall be recorded

account debit credit
4111-customer 120
706-services 100
44574-Tax invoiced 20

Then, when the invoice is paid, the following transaction shall be recorded

account debit credit
4111-customer 120
5121-Bank 120
44574-Tax invoiced 20
44571-Tax collected 20

How to implement that? I suggest the tax template should for each row gain a new optional account as the destination to move the tax funds when the payment is submitted.

ALTER TABLE TaxDetail ADD COLUMN `payment_account` text default null;

If the payment account is not specified, then the current behavior continues. If the payment_account is specified, the extra transaction is added when there is a payment submitted.
mildred added a commit to mildred/frappe-books that referenced this issue Dec 2, 2023
@mildred
frappe#755 Accounting for taxes on payments
248c81a 
When defining taxes, it is possible to define an additional payment
account that will be used during payments to move taxes from the
original tax account to this new payment tax account. This allows to
account for taxes only when payment is received.

Now payments can reference tax summary objects that will reference the
two accounts to move funds between when the payment is committed. Reuse
some of the Invoice code to generate these tax sumary objects.
mildred added a commit to mildred/frappe-books that referenced this issue Dec 2, 2023
@mildred
frappe#755 Accounting for taxes on payments
d12c74e 
When defining taxes, it is possible to define an additional payment
account that will be used during payments to move taxes from the
original tax account to this new payment tax account. This allows to
account for taxes only when payment is received.

Now payments can reference tax summary objects that will reference the
two accounts to move funds between when the payment is committed. Reuse
some of the Invoice code to generate these tax summary objects.
@mildred mildred self-assigned this Dec 2, 2023
@mildred mildred added the enhancement New feature or request label Dec 2, 2023
mildred added a commit to mildred/frappe-books that referenced this issue Dec 5, 2023
@mildred
feat: frappe#755 Accounting for taxes on payments
b0ec86d 
When defining taxes, it is possible to define an additional payment
account that will be used during payments to move taxes from the
original tax account to this new payment tax account. This allows to
account for taxes only when payment is received.

Now payments can reference tax summary objects that will reference the
two accounts to move funds between when the payment is committed. Reuse
some of the Invoice code to generate these tax summary objects.
mildred added a commit to mildred/frappe-books that referenced this issue Dec 5, 2023
@mildred
feat: frappe#755 Accounting for taxes on payments
1de83ae 
When defining taxes, it is possible to define an additional payment
account that will be used during payments to move taxes from the
original tax account to this new payment tax account. This allows to
account for taxes only when payment is received.

Now payments can reference tax summary objects that will reference the
two accounts to move funds between when the payment is committed. Reuse
some of the Invoice code to generate these tax summary objects.
mildred added a commit to mildred/frappe-books that referenced this issue Dec 21, 2023
@mildred
feat: frappe#755 Accounting for taxes on payments
a93fdd7 
When defining taxes, it is possible to define an additional payment
account that will be used during payments to move taxes from the
original tax account to this new payment tax account. This allows to
account for taxes only when payment is received.

Now payments can reference tax summary objects that will reference the
two accounts to move funds between when the payment is committed. Reuse
some of the Invoice code to generate these tax summary objects.
mildred added a commit to mildred/frappe-books that referenced this issue Dec 21, 2023
@mildred
feat: frappe#755 Accounting for taxes on payments
b4041f5 
When defining taxes, it is possible to define an additional payment
account that will be used during payments to move taxes from the
original tax account to this new payment tax account. This allows to
account for taxes only when payment is received.

Now payments can reference tax summary objects that will reference the
two accounts to move funds between when the payment is committed. Reuse
some of the Invoice code to generate these tax summary objects.
mildred added a commit that referenced this issue Dec 22, 2023
@mildred
feat: #755 Accounting for taxes on payments
2bffcda 
When defining taxes, it is possible to define an additional payment
account that will be used during payments to move taxes from the
original tax account to this new payment tax account. This allows to
account for taxes only when payment is received.

Now payments can reference tax summary objects that will reference the
two accounts to move funds between when the payment is committed. Reuse
some of the Invoice code to generate these tax summary objects.
@mildred mildred mentioned this issue Dec 22, 2023
Merged
@mildred mildred linked a pull request Dec 22, 2023 that will close this issue
feat: #755 Accounting for taxes on payments #789
Merged
mildred added a commit that referenced this issue Dec 27, 2023
@mildred
Merge pull request #789 from frappe/mildred/755-taxes-on-payments
0da912e 
feat: #755 Accounting for taxes on payments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mildred mildred

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #755 Accounting for taxes on payments frappe/books
1 participant
@mildred