New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stock return #682
feat: stock return #682
Conversation
@akshayitzme if this is a rewrite of #636 you can close it |
@18alantom could you review this PR when you get time? |
@@ -1,4 +1,4 @@ | |||
export type InvoiceStatus = 'Draft' | 'Saved' | 'Unpaid' | 'Cancelled' | 'Paid'; | |||
export type InvoiceStatus = 'Draft' | 'Saved' | 'Unpaid' | 'Cancelled' | 'Paid' | 'Return' | 'ReturnIssued'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many possible statuses they should be broken in to different groups. Will do it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akshayitzme along with all 29 review changes I need you to add the following two tests.
-
Using Batches:
- Create Shipment with two item rows
- Both should have the same item but different batches and different quantities
- Create its Shipment Return
- Ensure that quantities for both batches have been updated correctly
-
Using Serial Numbers:
- Create Purchase Receipt with an item row
- Item row should have more than one serial number
- Create its Purchase Receipt Return
- Ensure that quantities for both the Serial Numbers have been updated correctly
- Ensure that statuses for both Serial Numbers have been updated correctly
I need you to add these because this Stock Return PR doesn't take into account Batches and Serial Numbers and when one is returning Items using either of these it'll lead to unexpected bugs.
And so for the tests to pass you'll have to fix the handling of both in returns.
Looks mostly fine, minor seemingly non feature threatening issues, merging. |
This PR adds the functionality for Shipment Return & Purchase Reciept Return
Shipment Return
Purchase Receipt Return
Shipment, Purchase Receipt Return Statuses
Shows Return Balance Item Qty
Screen Capture
2023-07-03.11-31-18.mp4
Consider a Scenario where the following Shipment Entry is created.
then the Customer returns one qty of the Item.
If the Customer again returns one qty of the same Item, only the remaining Qty left to return (-1) is shown in the Shipment Form.