Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing printToPDF from electron window #827

Merged
merged 1 commit into from Feb 1, 2024
Merged

Fixing printToPDF from electron window #827

merged 1 commit into from Feb 1, 2024

Conversation

Isaac-GC
Copy link
Collaborator

Fixing an issue with Printing to a PDF.

Hi @mildred @18alantom

Testing this fix on local devices (linux, windows, and mac arm) it looks fine, but requesting verification JIC.

Thanks!

@Isaac-GC Isaac-GC linked an issue Jan 30, 2024 that may be closed by this pull request
Invoice print seems broken after the recent update #824
Closed
@Isaac-GC Isaac-GC mentioned this pull request Jan 30, 2024
Closed
mildred
mildred approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@mildred mildred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the PDF exports page size are off in v0.21.0, do you think that is from a dependency update?

Most probably, I could not save a PDF with your branch until I updated the dependencies... and it fixes the page size issue

@Isaac-GC
Copy link
Collaborator Author

Isaac-GC commented Feb 1, 2024

It seems the PDF exports page size are off in v0.21.0, do you think that is from a dependency update?

Most probably, I could not save a PDF with your branch until I updated the dependencies... and it fixes the page size issue

Correct --> It partly has to due to the dependency updates and specifically, the parameter option changes in the window.printToPDF. While the pdf's generated DO actually contain the expected contents... the actual contents are incredibly tiny due to the changes... But are fixed

@Isaac-GC Isaac-GC linked an issue Feb 1, 2024 that may be closed by this pull request
generated pdf's are blank #833
Closed
@Isaac-GC Isaac-GC merged commit 641ffac into master Feb 1, 2024
4 checks passed
@Isaac-GC Isaac-GC deleted the fix_electron_printpdf_bug branch February 1, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mildred mildred mildred approved these changes

@18alantom 18alantom Awaiting requested review from 18alantom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generated pdf's are blank Invoice print seems broken after the recent update
2 participants
@Isaac-GC @mildred