Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] More color and customization #23

Closed
chintan9 opened this issue Nov 2, 2017 · 10 comments
Closed

[Feature request] More color and customization #23

chintan9 opened this issue Nov 2, 2017 · 10 comments

Comments

@chintan9
Copy link

chintan9 commented Nov 2, 2017

It should have more color customization.

It also should have addons also.

@achillesrasquinha
Copy link
Contributor

With respect to color customisations, we use a color palette dedicated for http://github.com/frappe/frappe. We're working on rewriting the styles to SASS, will take a note of color customisations there

What sort of addons?

@chintan9
Copy link
Author

chintan9 commented Nov 3, 2017

for more type visualization.

What sort of addons?

@achillesrasquinha
Copy link
Contributor

You mean more charts?

@chintan9
Copy link
Author

chintan9 commented Nov 4, 2017

yes

@PatNeedham
Copy link

PatNeedham commented Nov 5, 2017

From the Create a Chart instructions:

  // Javascript
  let data = {
    labels: ["12am-3am", "3am-6am", "6am-9am", "9am-12pm",
      "12pm-3pm", "3pm-6pm", "6pm-9pm", "9pm-12am"],

    datasets: [
      {
        title: "Some Data", color: "light-blue",
        values: [25, 40, 30, 35, 8, 52, 17, -4]
      },
      {
        title: "Another Set", color: "violet",
        values: [25, 50, -10, 15, 18, 32, 27, 14]
      },
      {
        title: "Yet Another", color: "blue",
        values: [15, 20, -3, -15, 58, 12, -17, 37]
      }
    ]
  };
...

What if the color prop from title: "Some Data", color: "light-blue", could also accept hex and RGB values like title: "Some Data", color: "#91D4F9",?

Trying that currently makes the color become black:

image

@2f4f4f
Copy link

2f4f4f commented Nov 6, 2017

Some simple overlay patterns for color blind would be appreciated.

@pratu16x7
Copy link
Contributor

Color is surely a desired overhaul; we need to be able to allow for hex codes for more flexibility #47

@gpfunk
Copy link
Contributor

gpfunk commented Nov 14, 2017

Hey, thanks for the cool lib. I just submitted a PR which hopefully helps with this feature #71. Let me know if its along the right tracks.

@pratu16x7
Copy link
Contributor

We'll be doing a release shortly that resolves hex colors, thanks to @gpfunk.

@pratu16x7
Copy link
Contributor

Released. @PatNeedham Hex codes should be usable now.
@chintan9 Regarding the customisation request, please open a new issue that details the specifics.
@CamusAran Will look forward to including defaults for Deuteranopia, Protanopia, and Tritanopia, created a new issue for this (#76) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants