You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Frappé Charts version: Tested on latest, but existed prior as well
This is an extreme example (explicitly setting a width to 0), but its just an illustration for when a parent offsetWidth is invalid (<= 0). Not sure if this should be handled by the lib though, or whether the user should be required to making sure the container is setup correctly.
Expected Behaviour
The code to gracefully handle invalid parent offsetWidth
Actual Behaviour
The code ends up infinitely looping looking for a valid number
Steps to Reproduce:
charts/docs/index.html
Line 34 in 68906af
to
Frappé Charts version: Tested on latest, but existed prior as well
This is an extreme example (explicitly setting a width to 0), but its just an illustration for when a parent offsetWidth is invalid (<= 0). Not sure if this should be handled by the lib though, or whether the user should be required to making sure the container is setup correctly.
A fix that I'm using is switching:
charts/src/js/charts/AxisChart.js
Line 164 in 68906af
to:
if(this.is_series && allowed_space > 0) {
The text was updated successfully, but these errors were encountered: