feat(unicommerce): Sales Invoice creation through picklist #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oice through pick list
…oicethrough picklist
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #240 +/- ##
===========================================
- Coverage 40.91% 40.46% -0.46%
===========================================
Files 62 65 +3
Lines 4272 4340 +68
===========================================
+ Hits 1748 1756 +8
- Misses 2524 2584 +60
|
ankush
requested changes
Apr 27, 2023
sonali8848
changed the title
|
@sonali8848 are all review comments addressed? mark as ready for review and drop replies or mark them as resolved. |
|
Sure
…On Wed, May 10, 2023 at 11:33 AM Ankush Menat ***@***.***> wrote:
@sonali8848 <https://github.com/sonali8848> are all review comments
addressed? mark as ready for review and drop replies or mark them as
resolved.
—
Reply to this email directly, view it on GitHub
<#240 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3OTA7DH3N7EUJJHJ46MLX3XFMVUHANCNFSM6AAAAAAXG2J3NE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ankush
changed the title
ankush
requested changes
May 12, 2023
ecommerce_integrations/unicommerce/doctype/unicommerce_warehouses/unicommerce_warehouses.json
Outdated
Show resolved
Hide resolved
ecommerce_integrations/unicommerce/doctype/unicommerce_settings/unicommerce_settings.py
Outdated
Show resolved
Hide resolved
|
@sonali8848 I've reviewed again, last few changes pending after which it should be mergeable 👍 PS: In future please raise PR from personal forks or grant me access to 8848's fork otherwise I can't make changes to PRs. |
ankush
approved these changes
May 15, 2023
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
to Axentorllc/ecommerce_integrations
that referenced
this pull request
Jun 8, 2023
# [1.1.0](v1.0.0...v1.1.0) (2023-06-08) ### Bug Fixes * dont run invoice hooks if unicommerce isn't enabled ([cb5853f](cb5853f)) * ignore permissions while updating token ([fa461c8](fa461c8)) ### Features * (Uni-commerce) generate Delivery Note and sync item fields ([frappe#239](https://github.com/Axentorllc/ecommerce_integrations/issues/239)) ([f474301](f474301)) * **unicommerce:** Sales Invoice creation through picklist ([frappe#240](https://github.com/Axentorllc/ecommerce_integrations/issues/240)) ([8410c59](8410c59))
github-actions bot
pushed a commit
to mohsinalimat/ecommerce_integrations
that referenced
this pull request
Jun 16, 2023
# [1.8.0](v1.7.2...v1.8.0) (2023-06-16) ### Bug Fixes * 401 from parallel logins ([c5136fd](c5136fd)) * add defaults if mfg/expirty dates are missing ([ceb72e6](ceb72e6)) * better error message in case of HTTPError ([e70e586](e70e586)) * bump shopify api version ([203df24](203df24)) * capture curency code from order data ([5023dc0](5023dc0)) * cast to string before concatenating ([3cf612b](3cf612b)) * ci commits ([23e2234](23e2234)) * convert HTML to text while syncing description ([frappe#235](https://github.com/mohsinalimat/ecommerce_integrations/issues/235)) ([3546eca](3546eca)) * dont log error for item query ([2b3fa0c](2b3fa0c)) * dont run invoice hooks if unicommerce isn't enabled ([cb5853f](cb5853f)) * dont upload price on unicommerce ([6a526e1](6a526e1)) * handle inconsistency in state naming in Unicommerce ([50d3f1a](50d3f1a)) * ignore any possible exception from old deleted doctype ([32a62fc](32a62fc)) * ignore deleted variants from sync ([27c6907](27c6907)) * ignore permissions while updating token ([fa461c8](fa461c8)) * item wise tax detail missing on shipping lines ([frappe#232](https://github.com/mohsinalimat/ecommerce_integrations/issues/232)) ([08e41d2](08e41d2)) * misleading "success" message for DN when SO doesn't exist ([7ea6d15](7ea6d15)) * only log inventory sync failure in single log ([5e8928e](5e8928e)) * phone number mapping in address ([frappe#198](https://github.com/mohsinalimat/ecommerce_integrations/issues/198)) ([66a3782](66a3782)) * remove the trailing comma after the last SKU ([frappe#201](https://github.com/mohsinalimat/ecommerce_integrations/issues/201)) ([2894160](2894160)) * State mapping ([f158a4a](f158a4a)) * **unicommerce:** set `name` also when syncing new item ([6b2199f](6b2199f)) * **unicommerce:** use updated since instead of from_date ([91b2ee9](91b2ee9)) * use separate endpoint if item exists ([29944f3](29944f3)) * **UX:** show logs button on shopify setting ([9d131f5](9d131f5)) * wrap resync in savepoint ([fcd7680](fcd7680)) * zenoti settings shouldn't trigger unless enabled ([e79f701](e79f701)) ### Features * (Uni-commerce) generate Delivery Note and sync item fields ([frappe#239](https://github.com/mohsinalimat/ecommerce_integrations/issues/239)) ([f474301](f474301)) * item variant sync ([frappe#212](https://github.com/mohsinalimat/ecommerce_integrations/issues/212)) ([d1c6b22](d1c6b22)) * log clearing support ([0d8d5b5](0d8d5b5)) * **minor:** add raw data to doc to allow scripting ([26e2903](26e2903)) * set scan identifier as first barcode ([bc74a90](bc74a90)) * **shopify:** consolidate tax accounts in order ([4d60fb0](4d60fb0)) * **shopify:** resync item in bulk import ([bed3723](bed3723)) * **shopify:** sync shopify selling rate ([frappe#221](https://github.com/mohsinalimat/ecommerce_integrations/issues/221)) ([3ae06a6](3ae06a6)) * **unicommerce:** capture batch group field ([frappe#186](https://github.com/mohsinalimat/ecommerce_integrations/issues/186)) ([e8a932b](e8a932b)) * **unicommerce:** Sales Invoice creation through picklist ([frappe#240](https://github.com/mohsinalimat/ecommerce_integrations/issues/240)) ([8410c59](8410c59)) ### Performance Improvements * batch and commit inventory updates to shopify ([frappe#233](https://github.com/mohsinalimat/ecommerce_integrations/issues/233)) ([0dbdc0b](0dbdc0b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added one child table of order details in Pick List to get orders and Generate Invoice button at the top.
Once the picklist is saved, the sales orders are appended to the Order details child table in the pick list.
Once the sales invoice is generated, in the Order details table in the picklist, the sales invoice no. and pdf of the invoice are attached in the pick list.
