Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item Barcode table - Permission Error #16047

Closed
umairsy opened this issue Nov 21, 2018 · 5 comments
Closed

Item Barcode table - Permission Error #16047

umairsy opened this issue Nov 21, 2018 · 5 comments

Comments

@umairsy
Copy link
Member

umairsy commented Nov 21, 2018

Item Barcode table has text and select field, still permission error is coming

screenshot 2018-11-21 at 5 48 12 pm

@umairsy
Copy link
Member Author

umairsy commented Nov 21, 2018

Also, when add value in the barcode, there is a validation that value is not correct. But what should be the correct value based on barcode type, it doesn't indicate any where.

screenshot 2018-11-21 at 5 52 25 pm

@umairsy
Copy link
Member Author

umairsy commented Nov 21, 2018

Again, if we have Barcode table now, we still need Barcode field in the first section of the item (below Item Name)?

screenshot 2018-11-21 at 5 54 56 pm

@gbm001
Copy link
Contributor

gbm001 commented Nov 29, 2018

#15886

@gbm001
Copy link
Contributor

gbm001 commented Nov 29, 2018

Also, when add value in the barcode, there is a validation that value is not correct. But what should be the correct value based on barcode type, it doesn't indicate any where.

I recently made a pull request which limits the barcode validation to those that can actually be checked: UPC-A, EAN-8 and EAN-13 (so you can add new barcode types). These barcode standards include a check digit; you can use various online tools to generate valid barcodes or check identified ones.

I also wrote some tests for Item Barcodes, but I didn't write any documentation - perhaps it needs some to explain this.

#16006

@gbm001
Copy link
Contributor

gbm001 commented Nov 29, 2018

frappe/frappe#6570

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants