New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max recursion issues on supplier scorecard #22850

Open

MaxMorais opened this issue Jul 29, 2020 · 0 comments

Labels

Contributor

MaxMorais commented Jul 29, 2020 •

edited

erpnext/erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py

Line 25 in b91e9c6

self.save()

call the save function inside the on_update will generate a max recussion issue because the following flow

-> save()
|   -> run_post_save_methods()
|    |   |  -> on_update()
|    |   |   |   -> save() - |
|                            |
+ -------------------------- +

The text was updated successfully, but these errors were encountered:

ankush added the to-validate label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment