Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pricing Rule not applied for the child of selected Item Group #32696

Open
sjain17 opened this issue Oct 24, 2022 · 5 comments
Open

Pricing Rule not applied for the child of selected Item Group #32696

sjain17 opened this issue Oct 24, 2022 · 5 comments
Assignees

Comments

@sjain17
Copy link

sjain17 commented Oct 24, 2022

Information about bug

If we try to apply pricing on the item group tree then it is not working for child item groups.

For example - I have an Item group structured like this -
1 FMCG
1.1 GROCERY
1.2 BEVERAGES
1.1.1 FLOUR
1.1.2 FAST FOOD
1.1.3 INSTANT FOOD
1.2.1 BOTTLED WATER
1.2.2 COLD DRINKS

Now if I apply a pricing rule or promotional scheme on FMCG then it is not getting applied in GROCERY, BEVERAGES, FLOUR, FAST FOOD, INSTANT FOOD, BOTTLED WATER, and COLD DRINKS.

However, it should be applied to all child item groups as well.

Module

selling

Version

Frappe - Version-13
ERPNext - Version-13

Installation method

No response

Relevant log output / Stack trace / Full Error Message.

There is no error but the output is not as per expectations.
@maharshivpatel
Copy link
Contributor

@sjain17 Pricing rule is only applied on direct items of specified group. Pricing rule on nested group is not supported.

@sjain17
Copy link
Author

sjain17 commented Nov 13, 2022

Yeah, that's correct. Is it going to be available in the next release, it is very difficult to apply the pricing rule on the child item group level.

@maharshivpatel
Copy link
Contributor

Currently, There is no active development going on for this feature and lot of existing pricing rule setups will break if we introduce this. I will think about this you can also contribute by raising PR.

@sjain17
Copy link
Author

sjain17 commented Nov 13, 2022

Ok, we will do the development and raise a PR then.

@adityaduggal
Copy link
Contributor

I have checked it in version-13 its a bug since it used to work out of the box in version-12
Also the priority is somehow not getting fetched if we have multiple item group based Pricing Rules.
Suppose you have priority 1 Pricing Rule on FMCG
Then if you create a priority 2 Pricing Rule on GROCERY then ideally priority 2 should be applied on the Grocery Item Group instead of Priority 1 but in reality its Priority 1 which is getting applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants