Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packaging for distributions] Manual installation without Bench #33539

Closed
Spixmaster opened this issue Jan 4, 2023 · 3 comments
Closed

[Packaging for distributions] Manual installation without Bench #33539

Spixmaster opened this issue Jan 4, 2023 · 3 comments

Comments

@Spixmaster
Copy link

Spixmaster commented Jan 4, 2023

I would like to package ERPNext for the AUR so that more people can easily use this great software.

For this, an installation is needed without using Bench. Installing with python -m build -nw and python -m installer /proper/path/dist/*.whl does not install an executable. Therefore, I tried running every Python file but none of those starts a server.

Could you add an executable or could you tell me which Python file or perhaps method needs to be executed? In the latter case, I could create a pull request for the creation of an executable.

Thank you very much.

@ankush
Copy link
Member

ankush commented Jan 11, 2023

We have no plans to do this any time soon. In fact our intention is to just stick with Docker. Everything else is messy and difficult to manage for people.

@ankush ankush closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2023
@Thatoo
Copy link

Thatoo commented Dec 30, 2023

Well, we just ask for a bit more transparency and flexibility about what bench commands are doing.
For instance how is it that
bench new-site $site_name --db-name $db_name --db-password $db_pwd --force --admin-password $admin_pwd
require mysql root password whereas the database has been done before the bench command?
This sounds unsafe and is an unwanted behavior for such command.

@Thatoo
Copy link

Thatoo commented Jan 2, 2024

Well I found at that in new version of ERPnext, v15, there is a --no-setup-db that allow that.
The only problem remaining is that bench new-site command check these mysql variables

	"character_set_server": "utf8mb4",
	"collation_server": "utf8mb4_unicode_ci",

whereas it could be unnecessary if the database is created in advance like that :
sudo mysql -u root -e "CREATE DATABASE IF NOT EXISTS $db_name CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci;"

We don't need to set character and collation at server level if we do it at database level...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants