Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse payments after credit note #36170

Open
barredterra opened this issue Jul 17, 2023 · 7 comments
Open

Reuse payments after credit note #36170

barredterra opened this issue Jul 17, 2023 · 7 comments

Comments

@barredterra
Copy link
Collaborator

Information about bug

  1. Create a Sales Invoice and an according Payment Entry
  2. Issue a credit note against the Sales Invoice

Now what happens with the received payment?

  • There's no easy way to reconcile the Payment Entry with a different Sales Invoice.
  • There's no easy way to create a return Payment Entry.

Module

accounts

Version

14+

Installation method

None

Relevant log output / Stack trace / Full Error Message.

No response

@dj12djdjs
Copy link
Collaborator

@barredterra Correct me if I'm wrong, I think this PR should resolve this?
#36049

@barredterra
Copy link
Collaborator Author

Not sure if that is the right approach. Shouldn't the credit note be treated as the payment of the original invoice, and the payment becomes available again, for reconciliation with a different invoice?

@dj12djdjs
Copy link
Collaborator

I guess it depends.

In my case we generate a lot of credit notes after the payment has been received and reconciled. 99% of the time that payment closes a hundred invoices or so. So if a credit note is issued all of a sudden a payment entry that was closed 6 months ago for $13,000 now has an unallocated amount of $20.00.

So when we generate a customer statement for July, there is a credit entry for $20.00 showing in January posting date. Is a bit confusing to the customer.

Another possibility is, we reconcile that $20.00 unallocated balance towards the statement balance before printing the statement for customer, but then they don't see $20.00 credit on their statement.

I think the credit note should be a payment of it's self to close or partially close the next statement balance.

@barredterra
Copy link
Collaborator Author

@dj12djdjs okay, makes sense.

My reason for making the original payment entry available again was that we won't create money out of nothing. If there was no payment entry, we cannot make it available again. But we can create a credit note for an invoice that has not been paid in the first place. If that would become available for reconciliation, we created money out of nothing. Is this taken care of by your PR?

@dj12djdjs
Copy link
Collaborator

@barredterra Good point, I'll do further testing

@dj12djdjs
Copy link
Collaborator

My PR doesn't solve the problem of posting date, because it will make the original invoice reconcilable again, not the credit note.

Seem's like another approach needs to be taken. I think this PR #35330 actually covers this.

@msalim79
Copy link

msalim79 commented Oct 5, 2023

Would like to add to this ,

  1. Once the credit note has been submitted against an invoice , "voucher type" in the ledgers should reflect " Sales Credit Note" this would make easy for end users and customers alike to read their statements.
  2. Currently to allocate a "credit note" to a new invoice it is done via payment doctype , user needs to add a new line "Sales Invoice" however identifing the correct transaction is difficult for the end user.One could easly get confused and frustrated on which to select. Also to recall that a customer has a "credit" after some time makes it difficult for the end user.
  3. Would it not make sense to allocate a "Sales Credit Note" to a newly raised "Sales Invoice" similar to advanced payment feature? For e.g Total Amount = $1000 less "Sales Credit Note" = $200 , final payment owing is $800. Customer then pays $800 via payment entry doctype.

CreditNoteAllocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants