Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog not refreshed in the "Serial No And Batch Selector" dialog when using scan to add new serial #41535

Open
ZhangLianK opened this issue May 18, 2024 · 3 comments
Labels

Comments

@ZhangLianK
Copy link

Information about bug

when using scan in the "Serial No And Batch Selector", the scanned serial is added but the screen is not refreshed.
when execute cur_dialog.refresh() in the js console, the scanned serial displayed.

Module

stock

Version

ERPNext 15

Installation method

manual install

Relevant log output / Stack trace / Full Error Message.

No response

@ZhangLianK ZhangLianK added the bug label May 18, 2024
@ZhangLianK
Copy link
Author

update_serial_batch_no() {

frappe.call({
method: "erpnext.stock.doctype.serial_and_batch_bundle.serial_and_batch_bundle.get_batch_no_from_serial_no",
args: {
serial_no: scan_serial_no,
},
callback: (r) => {
if (r.message) {
this.dialog.fields_dict.entries.df.data.push({
serial_no: scan_serial_no,
batch_no: r.message,
});

						this.dialog.fields_dict.scan_serial_no.set_value("");
					}
				},
			});

@ZhangLianK
Copy link
Author

@rohitwaghchaure
could you please have a look on this issue? I think in the callback function should have a refresh.

@nabinhait
Copy link
Member

Can't replicate in latest version. Can you make a video and attach it here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants