fix: commit before ddl

frappe · Mar 11, 2024 · 092bd0e · 092bd0e
1 parent d6bff86
commit 092bd0e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/frappe/database/mariadb/database.py b/frappe/database/mariadb/database.py
@@ -437,7 +437,7 @@ def updatedb(self, doctype, meta=None):
 			db_table.validate()
 
 			db_table.sync()
-			self.begin()
+			self.commit()
 
 	def get_database_list(self):
 		return self.sql("SHOW DATABASES", pluck=True)

diff --git a/frappe/database/mariadb/schema.py b/frappe/database/mariadb/schema.py
@@ -102,7 +102,7 @@ def alter(self):
 				if query_parts:
 					query_body = ", ".join(query_parts)
 					query = f"ALTER TABLE `{self.table_name}` {query_body}"
-					frappe.db.sql(query)
+					frappe.db.sql_ddl(query)
 
 		except Exception as e:
 			if query := locals().get("query"):  # this weirdness is to avoid potentially unbounded vars