Skip to content

Commit

Permalink
fix(report_utils): ensure that delimiter and separator can't be empty
Browse files Browse the repository at this point in the history
This results in them setting as `undefined`, which ends up as a string
in python, and the delimiter ends up as `'u'`, and the separator as
`'undefined'`.

(cherry picked from commit af611d4)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
  • Loading branch information
akhilnarang committed Apr 30, 2024
1 parent 1a2411c commit 5301516
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions frappe/public/js/frappe/views/reports/report_utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -256,8 +256,12 @@ frappe.report_utils = {

dialog.fields_dict["file_format"].df.onchange = () => update_csv_preview(dialog);
dialog.fields_dict["csv_quoting"].df.onchange = () => update_csv_preview(dialog);
dialog.fields_dict["csv_delimiter"].df.onchange = () => update_csv_preview(dialog);

dialog.fields_dict["csv_delimiter"].df.onchange = () => {
if (!dialog.get_value("csv_delimiter")) {
dialog.set_value("csv_delimiter", ",");
}
update_csv_preview(dialog);
};
return dialog;
},

Expand Down

0 comments on commit 5301516

Please sign in to comment.