fix: unsubscribe from task after completion

Also update event name to be more logical Signed-off-by: Akhil Narang <me@akhilnarang.dev>
frappe · Mar 13, 2024 · 6a5af14 · 6a5af14
1 parent 0ec3e4a
commit 6a5af14
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/frappe/public/js/frappe/list/bulk_operations.js b/frappe/public/js/frappe/list/bulk_operations.js
@@ -117,10 +117,12 @@ export default class BulkOperations {
 				.then((response) => {
 					let task_id = response.message.task_id;
 					frappe.realtime.task_subscribe(task_id);
-					frappe.realtime.on(`task_progress:${task_id}`, (data) => {
+					frappe.realtime.on(`task_complete:${task_id}`, (data) => {
 						frappe.msgprint(
 							`Please click <a href=${data.file_url} target="_blank">here</a> to download the PDF`
 						);
+						frappe.realtime.task_unsubscribe(task_id);
+						frappe.realtime.off(`task_complete:${task_id}`);
 					});
 					dialog.hide();
 				});

diff --git a/frappe/utils/print_format.py b/frappe/utils/print_format.py
@@ -208,7 +208,7 @@ def _download_multi_pdf(
 				}
 			)
 			_file.save()
-			frappe.publish_realtime(f"task_progress:{task_id}", message={"file_url": _file.unique_url})
+			frappe.publish_realtime(f"task_complete:{task_id}", message={"file_url": _file.unique_url})
 		else:
 			frappe.local.response.filecontent = merged_pdf.getvalue()
 			frappe.local.response.type = "pdf"