fix: Use doctype setting to set auto-extracted file as private

- Use `make_attachments_public` to determine the file privacy while auto creating files from the text editor field
- Currently, all files in the text editor field are automatically public

frappe/core/doctype/file/test_file.py

@@ -717,16 +717,18 @@ def tearDown(self) -> None:
 
 class TestFileUtils(FrappeTestCase):
 	def test_extract_images_from_doc(self):
+		is_private = not frappe.db.get_value("DocType", "ToDo", "make_attachments_public")
+
 		# with filename in data URI
 		todo = frappe.get_doc(
 			{
 				"doctype": "ToDo",
 				"description": 'Test <img src="data:image/png;filename=pix.png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mNkYAAAAAYAAjCB0C8AAAAASUVORK5CYII=">',
 			}
 		).insert()
-		self.assertTrue(frappe.db.exists("File", {"attached_to_name": todo.name}))
-		self.assertIn('<img src="/files/pix.png">', todo.description)
-		self.assertListEqual(get_attached_images("ToDo", [todo.name])[todo.name], ["/files/pix.png"])
+		self.assertTrue(frappe.db.exists("File", {"attached_to_name": todo.name, "is_private": is_private}))
+		self.assertIn('<img src="/private/files/pix.png">', todo.description)
+		self.assertListEqual(get_attached_images("ToDo", [todo.name])[todo.name], ["/private/files/pix.png"])
 
 		# without filename in data URI
 		todo = frappe.get_doc(

frappe/core/doctype/file/utils.py

@@ -216,7 +216,7 @@ def get_file_name(fname: str, optional_suffix: str | None = None) -> str:
 
 def extract_images_from_doc(doc: "Document", fieldname: str):
 	content = doc.get(fieldname)
-	content = extract_images_from_html(doc, content)
+	content = extract_images_from_html(doc, content, is_private=(not doc.meta.make_attachments_public))
 	if frappe.flags.has_dataurl:
 		doc.set(fieldname, content)