fix: Problems while using translations via Globe Symbol

Co-authored-by: Vama Mehta <vama.mehta@inqubit.in>
frappe · Sep 6, 2021 · 92155fc · 92155fc
1 parent 57e96a1
commit 92155fc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/frappe/public/js/frappe/form/controls/base_control.js b/frappe/public/js/frappe/form/controls/base_control.js
@@ -114,7 +114,7 @@ frappe.ui.form.Control = Class.extend({
 				if (!this.doc.__islocal) {
 					new frappe.views.TranslationManager({
 						'df': this.df,
-						'source_name': value,
+						'source_name': this.value,
 						'target_language': this.doc.language,
 						'doc': this.doc
 					});

diff --git a/frappe/translate.py b/frappe/translate.py
@@ -766,7 +766,10 @@ def update_translations_for_source(source=None, translation_dict=None):
 		return
 
 	translation_dict = json.loads(translation_dict)
-
+
+	if is_html(source):
+		source = strip_html_tags(source)
+
 	# for existing records
 	translation_records = frappe.db.get_values('Translation', { 'source_name': source }, ['name', 'language'],  as_dict=1)
 	for d in translation_records: