fix: no API call required to set cookie in browser

frappe · Jul 22, 2023 · d2becc7 · d2becc7
1 parent 319da42
commit d2becc7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/frappe/translate.py b/frappe/translate.py
@@ -1320,11 +1320,6 @@ def get_all_language_with_name():
 		return frappe.cache.get_value("languages", get_language_codes)
 
 
-@frappe.whitelist(allow_guest=True)
-def set_preferred_language_cookie(preferred_language: str):
-	frappe.local.cookie_manager.set_cookie("preferred_language", preferred_language)
-
-
 def get_preferred_language_cookie():
 	return frappe.request.cookies.get("preferred_language")
 

diff --git a/frappe/website/js/website.js b/frappe/website/js/website.js
@@ -394,14 +394,9 @@ $.extend(frappe, {
 					language_switcher.val(language);
 					document.documentElement.lang = language;
 					language_switcher.change(() => {
-						let lang = language_switcher.val();
-						frappe
-							.call("frappe.translate.set_preferred_language_cookie", {
-								preferred_language: lang,
-							})
-							.then(() => {
-								window.location.reload();
-							});
+						const lang = language_switcher.val();
+						document.cookie = `preferred_language=${lang}`;
+						window.location.reload();
 					});
 				});
 		}