fix: delete old user notification settings when merging users (#26604)

frappe · May 30, 2024 · e97a56b · e97a56b
1 parent 847012e
commit e97a56b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/frappe/core/doctype/user/user.py b/frappe/core/doctype/user/user.py
@@ -543,6 +543,10 @@ def on_trash(self):
 			frappe.throw(_("You can disable the user instead of deleting it."), frappe.LinkExistsError)
 
 	def before_rename(self, old_name, new_name, merge=False):
+		# if merging, delete the old user notification settings
+		if merge:
+			frappe.delete_doc("Notification Settings", old_name, ignore_permissions=True)
+
 		frappe.clear_cache(user=old_name)
 		self.validate_rename(old_name, new_name)