Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App name not showing on login page #13802

Closed
ollyboy opened this issue Jul 28, 2021 · 2 comments
Closed

App name not showing on login page #13802

ollyboy opened this issue Jul 28, 2021 · 2 comments
Labels

Comments

@ollyboy
Copy link
Contributor

ollyboy commented Jul 28, 2021

The latest development, clean bench update

Building a new app, Can change logo fine but app_name or app_title in hooks.py does not change the login screen from "login to Frappe" to "login to [my_app]"

image

Is there an issue in login.html ??

_('Login to {0}').format(app_name or _("Frappe"))

I can't see it :(

@ollyboy ollyboy added the bug label Jul 28, 2021
@ollyboy
Copy link
Contributor Author

ollyboy commented Jul 29, 2021

I think that app_name will always be "frappe" as the way this is overwritten is a patch in ERPNext called set_app_name.py

import frappe
from frappe import _

def execute():
	frappe.reload_doctype("System Settings")
	settings = frappe.get_doc("System Settings")
	settings.db_set("app_name", "ERPNext", commit=True)

Guess I can do this but it would be better if there was a site setting override for app_name

@rmehta
Copy link
Member

rmehta commented Aug 23, 2021

#14020

@rmehta rmehta closed this as completed Aug 23, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants