Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(minor): Added app_name and app_logo in Website Settings #14020

Merged
merged 1 commit into from Aug 23, 2021
Merged

feat(minor): Added app_name and app_logo in Website Settings #14020

merged 1 commit into from Aug 23, 2021

Conversation

rmehta
Copy link
Member

@rmehta rmehta commented Aug 23, 2021 •
edited

Screenshot 2021-08-23 at 9 44 21 PM

@rmehta rmehta requested review from surajshetty3416 and a team as code owners August 23, 2021 16:13
@rmehta rmehta merged commit 52d58ae into frappe:develop Aug 23, 2021
@rmehta rmehta mentioned this pull request Aug 23, 2021
Closed
@erpwala
Copy link

erpwala commented Oct 2, 2021

Not showing Login Menu in Website -->Website Settings
in : ERPNext: v13.11.1 (version-13) Frappe Framework: v13.11.0 (version-13)

pls recheck

2
p1

@surajshetty3416
Copy link
Member

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2021

Command backport version-13-hotfix: success

Backports have been created

@mergify mergify bot mentioned this pull request Oct 4, 2021
Merged
@surajshetty3416
Copy link
Member

@rmehta we also use app_logo_url inside the desk... this feature might lead to different app logos on the website and on the desk navbar. Should we instead move this to System Settings since we already have the app name in System Settings?

@rmehta
Copy link
Member Author

rmehta commented Oct 4, 2021

this is related to website, so should be in website settings. Maybe a different "desk settings" ?

@surajshetty3416
Copy link
Member

We already have "Navbar Settings" where users can set their desired logo for their desk navbar. For now, that'll work.

@rohitwaghchaure rohitwaghchaure mentioned this pull request Oct 20, 2021
Merged
@surajshetty3416 surajshetty3416 mentioned this pull request Jan 18, 2022
Closed
@surajshetty3416 surajshetty3416 mentioned this pull request Jul 18, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmehta @erpwala @surajshetty3416