Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problems while using translations via Globe Symbol #14118

Closed
vamagithub opened this issue Sep 4, 2021 · 1 comment · Fixed by #14128
Closed

Problems while using translations via Globe Symbol #14118

vamagithub opened this issue Sep 4, 2021 · 1 comment · Fixed by #14128
Labels
bug

Comments

@vamagithub
Copy link
Contributor

vamagithub commented Sep 4, 2021 •
edited

Description / Context information (for bug reports)

There are 2 issues -

Issue - 1
While updating translations using Globe Symbol, system generates duplicate rows of translations for records added in Description

duplicates.mp4

Issue - 2
When clicking on the globe button of Item-2, values from the prev edited item (Item-1) are displayed.In order to refresh the correct values of Item-2, page reload is required.

reload.mp4

Output of bench version

We Checked on version-12 and version-13
Problem is consistent for versions

Bench 5.5.0
ERPNext: v13.10.0 (version-13)
Frappe Framework: v13.10.0 (version-13)

Bench 5.5.0
ERPNext: v12.23.0 (version-12)
Frappe Framework: v12.20.0 (version-12)

Steps to reproduce the issue

Check Translate On Description field for Item master.
@vamagithub vamagithub added the bug label Sep 4, 2021
@vamagithub vamagithub changed the title Updating translations via Globe Symbol generates duplicate translations Problems while using translations via Globe Symbol Sep 4, 2021
vamagithub pushed a commit to vamagithub/frappe that referenced this issue Sep 4, 2021
@VamaINQ
(fix) Problems while using translations via Globe Symbol frappe#14118
e5369f7
vamagithub pushed a commit to vamagithub/frappe that referenced this issue Sep 4, 2021
@VamaINQ
(fix) Problems while using translations via Globe Symbol -v12 frappe#…
4d2aef4 
…14118
This was referenced Sep 6, 2021
Merged
Merged
gavindsouza pushed a commit that referenced this issue Sep 6, 2021
@vamagithub @VamaINQ
(fix) Problems while using translations via Globe Symbol #14118 (#14120)
40f2e91 
Co-authored-by: Vama Mehta <vama.mehta@inqubit.in>
mergify bot pushed a commit that referenced this issue Sep 6, 2021
@vamagithub
(fix) Problems while using translations via Globe Symbol #14118 (#14120)
04c3fd4 
Co-authored-by: Vama Mehta <vama.mehta@inqubit.in>
(cherry picked from commit 40f2e91)
@gavindsouza
Copy link
Collaborator

Validated the issue on develop as well. Thanks for the fix!

@gavindsouza gavindsouza mentioned this issue Sep 6, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Problems while using translations via Globe Symbol (develop) frappe/frappe
2 participants
@vamagithub @gavindsouza