Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical: Only system managers can print documents #14372

Closed
rtdany10 opened this issue Oct 7, 2021 · 7 comments · Fixed by #14373 or #14376
Closed

Critical: Only system managers can print documents #14372

rtdany10 opened this issue Oct 7, 2021 · 7 comments · Fixed by #14373 or #14376

Comments

@rtdany10
Copy link
Contributor

rtdany10 commented Oct 7, 2021

image

ERPNext: v13.12.0 (HEAD)
Frappe Framework: v13.12.0 (HEAD)

To replicate:

  1. Login as a user without System Manager role.
  2. Open any document
  3. Go to print view
  4. Try to print(click on the print button)
@rtdany10 rtdany10 added the bug label Oct 7, 2021
@rtdany10
Copy link
Contributor Author

rtdany10 commented Oct 7, 2021

Seems to be introduced in #14151
Only system managers has access to Network Printer Settings.

Solution: Read only access to All users should be given.

@rtdany10
Copy link
Contributor Author

rtdany10 commented Oct 7, 2021

Also, on FC, we can't even add network printers:
image

Our operations are partially affected due to this :/

@mohsinalimat
Copy link

mohsinalimat commented Oct 7, 2021

@rtdany10 Same issue with me on self hosted.

@rtdany10
Copy link
Contributor Author

rtdany10 commented Oct 7, 2021

@rtdany10 Same issue with me on self hosted.

You can go to Role Permission Manager and give every role read access to Network Printer Settings. That should fix the issue.

@rtdany10
Copy link
Contributor Author

rtdany10 commented Oct 7, 2021

@surajshetty3416 @nidhipurohit11 @anupamvs Please reopen this as the permission issue still needs to be addressed.

@ankush
Copy link
Member

ankush commented Oct 7, 2021

#14376

This should fix permission issue as well

@rtdany10
Copy link
Contributor Author

rtdany10 commented Oct 7, 2021

Thank you team for the prompt response! Much love! <3
💯 🥇

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants