Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: network printer settings permission issue #14376

Merged
merged 2 commits into from Oct 7, 2021
Merged

fix: network printer settings permission issue #14376

merged 2 commits into from Oct 7, 2021

Conversation

anupamvs
Copy link
Contributor

@anupamvs anupamvs commented Oct 7, 2021 •
edited by surajshetty3416

fixes #14372

@anupamvs anupamvs requested a review from a team as a code owner October 7, 2021 05:55
@anupamvs anupamvs requested review from hasnain2808 and removed request for a team October 7, 2021 05:55
@anupamvs
Copy link
Contributor Author

anupamvs commented Oct 7, 2021

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2021

Command backport version-13-hotfix: pending

backport version-13-hotfix is pending

@codecov
Copy link

codecov bot commented Oct 7, 2021 •
edited

Codecov Report

Merging #14376 (5387e48) into develop (c8efaf4) will decrease coverage by 2.72%.
The diff coverage is n/a.

❗ Current head 5387e48 differs from pull request most recent head 02091df. Consider uploading reports for the commit 02091df to get more accurate results

@@             Coverage Diff             @@
##           develop   #14376      +/-   ##
===========================================
- Coverage    52.42%   49.70%   -2.73%     
===========================================
  Files          749      742       -7     
  Lines        64788    64471     -317     
  Branches      5469     5407      -62     
===========================================
- Hits         33966    32043    -1923     
- Misses       27429    28556    +1127     
- Partials      3393     3872     +479
Flag Coverage Δ
server 56.27% <ø> (+0.01%) ⬆️
ui-tests 37.67% <ø> (-7.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush mentioned this pull request Oct 7, 2021
Closed
@anupamvs anupamvs force-pushed the network-printer-settings-permission branch from ab451f1 to 5387e48 Compare October 7, 2021 06:43
@surajshetty3416 surajshetty3416 merged commit 9761809 into frappe:develop Oct 7, 2021
@mergify mergify bot mentioned this pull request Oct 7, 2021
Merged
@mergify
Copy link
Contributor

mergify bot commented Oct 7, 2021

Command backport version-13-hotfix: success

Backports have been created

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hasnain2808 hasnain2808 Awaiting requested review from hasnain2808 hasnain2808 was automatically assigned from frappe/frappe-review-team

Assignees
No one assigned
Labels
critical
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Critical: Only system managers can print documents
2 participants
@anupamvs @surajshetty3416