Allow all users to save customized reports

[barredterra]

User story

If a user can see a report (type: Report Builder), he can add or remove columns and filters to customize his view. Consequently he should also be able to save this current view for future use.

Situation

At the moment, only users with role "Report Manager" can save customized reports. A report manager can create, edit, delete all custom reports. This is way too permissive for a normal user.

Proposed solution

A user can always customize the reports he can see, for himself. So everybody should have the permission to create, edit, delete his own reports as long as this only means narrowing down an existing report.

[sagarvora]

#15494 is a good start.

Further recommendations:

• Save button should be visible only if User is Report's owner or Report Manager.
• A button to delete a report will be visible in Report View based on following conditions:
  • Report is of type Report Builder
  • User is owner / report manager
  • It is not a standard report

I think that the restriction to narrow down the existing report is not really necessary as permissions are already being checked when rendering the report using frappe.get_list.

[sagarvora]

Perhaps we can allow this for Query Reports as well (with a restriction that only columns be set)?

[barredterra]

@sagarvora that would be even better