Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow all users to customize reports of type Report Builder #15918

Merged
merged 8 commits into from Feb 11, 2022

Conversation

sagarvora
Copy link
Collaborator

@sagarvora sagarvora commented Feb 9, 2022

Resolves #15074
Continuation of #15494

This PR allows a report of type Report Builder to be created / edited / deleted by any user. This is accomplished without changing permissions for the Report DocType, since this PR only allows non-standard reports of type Report Builder to be saved. They can then be edited / deleted by owner or someone else with requisite permissions.

Delete button in Report View:

image

Docs to be added after preliminary review. Until then: no-docs

@sagarvora sagarvora marked this pull request as draft February 9, 2022 06:54
@sagarvora
Copy link
Collaborator Author

sagarvora commented Feb 9, 2022

@ankush Where can I fix this false negative? We should probably ignore all files starting with test_
Fixed in frappe/semgrep-rules#6

@sagarvora sagarvora changed the title feat: Allow users to customize their own reports feat: Allow all to customize reports of type Report Builder Feb 9, 2022
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #15918 (976c3be) into develop (71ceb49) will increase coverage by 0.03%.
The diff coverage is 60.00%.

@@             Coverage Diff             @@
##           develop   #15918      +/-   ##
===========================================
+ Coverage    53.74%   53.77%   +0.03%     
===========================================
  Files          756      756              
  Lines        66631    66660      +29     
  Branches      5631     5639       +8     
===========================================
+ Hits         35812    35849      +37     
+ Misses       27400    27372      -28     
- Partials      3419     3439      +20     
Flag Coverage Δ
server 57.66% <71.42%> (+0.04%) ⬆️
ui-tests 46.70% <41.17%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sagarvora sagarvora marked this pull request as ready for review February 9, 2022 08:24
@sagarvora sagarvora changed the title feat: Allow all to customize reports of type Report Builder feat: Allow all users to customize reports of type Report Builder Feb 9, 2022
frappe/desk/reportview.py Outdated Show resolved Hide resolved
@sagarvora
Copy link
Collaborator Author

UI test passing locally, seems to be flaky:

image

@surajshetty3416 surajshetty3416 merged commit 733718a into frappe:develop Feb 11, 2022
@surajshetty3416 surajshetty3416 deleted the report_fix branch February 11, 2022 08:00
@barredterra
Copy link
Collaborator

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Feb 11, 2022

backport version-13-hotfix

✅ Backports have been created

mergify bot added a commit that referenced this pull request Feb 12, 2022
…-15918

feat: Allow all users to customize reports of type Report Builder (backport #15918)
@sagarvora
Copy link
Collaborator Author

Docs: https://www.frappeframework.com/docs/v13/user/en/desk/reports/report-builder#updating-or-deleting-custom-reports

@sharmanakul
Copy link

@sagarvora another issue I observed (although not replicated every time) was that sometimes it takes a lot of time for the newly created report to reflect in the report selector dropdown.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow all users to save customized reports
4 participants