-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: remove naming series from log-like doctypes #16823
Conversation
- webhook request log - access log
Codecov Report
@@ Coverage Diff @@
## develop #16823 +/- ##
===========================================
- Coverage 58.09% 56.30% -1.80%
===========================================
Files 765 765
Lines 68616 68616
Branches 5956 5956
===========================================
- Hits 39863 38632 -1231
- Misses 25154 26385 +1231
Partials 3599 3599
Flags with carried forward coverage won't be shown. Click here to find out more. |
LGTM 馃憤 PS:
frappe/frappe/model/__init__.py Lines 117 to 132 in ee40bda
|
Patching existing data is quite painful. Also equivalent doesn't exist for PG. |
- webhook request log - access log (cherry picked from commit d1938ee)
# [13.29.0](v13.28.0...v13.29.0) (2022-05-10) ### Bug Fixes * bad query if user has ' in the email address (backport [#16796](#16796)) ([#16834](#16834)) ([6cb2955](6cb2955)) * frappe.throw in case of list of errors ([#16855](#16855)) ([#16857](#16857)) ([27a9d2d](27a9d2d)) * properly validate google sheets url ([#16683](#16683)) ([f0d3a02](f0d3a02)) ### Features * disable change log ([1897af2](1897af2)) ### Performance Improvements * remove naming series from log-like doctypes ([#16823](#16823)) ([#16826](#16826)) ([bf2d6cd](bf2d6cd))
Removed naming series from:
These are unnecessary and make operations sequential because of the naming series lock.
Example: 20+ parallel workers effectively operating sequentially because they are all waiting for lock for incrementing series counter on a log table 馃捀
PS: If you want it on your site, it's easy to add it back from "Customize form" having this by default isn't required.