fix: encode docname when routing (backport #17092) #17374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
(cherry picked from commit c8777c5) # Conflicts: # frappe/public/js/frappe/list/list_view.js
|
this will need some additional changes @surajshetty3416 - please don't merge for now :) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #17374 +/- ##
=========================================
Coverage 62.35% 62.35%
=========================================
Files 753 753
Lines 68079 67862 -217
Branches 5970 5968 -2
=========================================
- Hits 42450 42318 -132
+ Misses 22136 22041 -95
- Partials 3493 3503 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
phot0n
reviewed
Sep 5, 2022
|
Seems to be working now: Screen.Recording.2022-09-07.at.8.52.55.PM.mov |
phot0n
reviewed
Sep 7, 2022
phot0n
added
squash
backport version-14-hotfix
|
realized this would need to be backported to v14-hotfix after #17537 is backported 😢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #17092 done by Mergify.