fix: Append to - misleading message #17718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I finally just replaced Status by Sender so why does the semantic test fail ? |
Codecov Report
@@ Coverage Diff @@
## develop #17718 +/- ##
===========================================
- Coverage 57.95% 56.77% -1.18%
===========================================
Files 757 749 -8
Lines 68368 67741 -627
Branches 5912 5783 -129
===========================================
- Hits 39623 38462 -1161
- Misses 25101 25723 +622
+ Partials 3644 3556 -88
Flags with carried forward coverage won't be shown. Click here to find out more. |
You're supposed to follow https://conventionalcommits.org/ guidelines for all commits, anyway we can just squash this for now but sharing for reference. |
ankush
changed the title
Okay, I didn't know, I will check it. Thanks for the information. So is there a possibility to add the additional sentence too (the one that I deleted in this [commit] )(6ffce27) |
phot0n
reviewed
Aug 10, 2022
Better syntax and typo corrections Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
* minor: add incoming and outgoing server fields to list view
phot0n
approved these changes
Aug 10, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 10, 2022
* chore: remove append_to field from email domain doctype * minor: add incoming and outgoing server fields to list view Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com> (cherry picked from commit 62420f7)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
# [14.1.0](v14.0.2...v14.1.0) (2022-08-11) ### Bug Fixes * add_user_permission with applicale_for arg set not updating in user permission ([804ce72](804ce72)) * assume parentfield to be set and valid ([e28674b](e28674b)) * check permlevel only if > 0 ([63f2cf5](63f2cf5)) * consistent fieldnames and keep port alongside server field ([c4f1619](c4f1619)) * **db:** Log mogrified queries ([ba1cdf8](ba1cdf8)) * dont init child doc ([94b760c](94b760c)) * dont pass doc to tooltip formatter on reportview ([d049c87](d049c87)) * german translations ([#17663](#17663)) ([#17771](#17771)) ([fd3eaa6](fd3eaa6)) * get correct doc when checking child table permission ([9b89dc6](9b89dc6)) * handle permlevel ([06ebd95](06ebd95)) * ignore built assets in translation ([53357e2](53357e2)) * ignore forms without docs in realtime events ([afc060f](afc060f)) * init only existing single doctypes ([75b6a33](75b6a33)) * limit allowed attributes for lazy images ([#17775](#17775)) ([1311564](1311564)) * **patch:** update multi step webform's Section Break fields to Page Break ([#17797](#17797)) ([#17798](#17798)) ([b3dc4c0](b3dc4c0)) * raise ImplicitCommitError instead of bare exception ([e2c6497](e2c6497)) * reverse logic for failing permission check ([7891674](7891674)) * **sanitize-html:** allow all data-* attrs ([9b94479](9b94479)) * send all messages on boot instead of scanning ([d61b7e8](d61b7e8)) * update append_to misleading message in email account ([#17718](#17718)) ([#17796](#17796)) ([cd86462](cd86462)) * **ux:** email domain doctype ([48c4a8d](48c4a8d)) * Webform Misc Fix (backport [#17642](#17642)) ([#17746](#17746)) ([86f9fbc](86f9fbc)) ### Features * JS extractor and custom JS parser ([fed4ae9](fed4ae9)) * **minor:** add connection link to email accounts in email domain ([821549d](821549d)) * **minor:** fetch attachment_limit from get_max_file_size api ([5190a49](5190a49)) * modified parser for frappe JS translate syntax ([0e87d21](0e87d21)) * Multilanguage sites: language selector only will show "enabled" languages and language default always will be System default ([#17745](#17745)) ([e5b8a47](e5b8a47)) * use AST to extract translation sources ([e02a73f](e02a73f)) ### Performance Improvements * reduce DB calls made in `get_fetch_values` ([#17671](#17671)) ([#17739](#17739)) ([dc19f69](dc19f69)) ### Reverts * Remove emoji from doctype ([c102124](c102124))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I propose this new version to fix the aberrant current message describing the requirements of the email Append to function.
To match with the current sentence structure, I propose to simply replace Status by Sender (as it is Sender and not Status which is mandatory). The complementary instructions are in a different sentence, so I hope it will not lead to a semantic problem this time.
If it is still not right, there are always the possibility to remove the additionnal sentence, but it reduced the quality of the information provided.
Other Changes:
append_tofield from email domain doctype