fix(patch): update multi step webform's Section Break fields to Page Break (backport #17797) #17798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
mergify
bot
requested review from
surajshetty3416,
gavindsouza and
a team
as code owners
github-actions
bot
added
the
add-test-cases
Codecov Report
@@ Coverage Diff @@
## version-14-hotfix #17798 +/- ##
==================================================
Coverage 57.76% 57.77%
==================================================
Files 759 759
Lines 68613 68613
Branches 5971 5971
==================================================
+ Hits 39637 39638 +1
+ Misses 25537 25536 -1
Partials 3439 3439
Flags with carried forward coverage won't be shown. Click here to find out more. |
shariquerik
removed
the
add-test-cases
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 11, 2022
# [14.1.0](v14.0.2...v14.1.0) (2022-08-11) ### Bug Fixes * add_user_permission with applicale_for arg set not updating in user permission ([804ce72](804ce72)) * assume parentfield to be set and valid ([e28674b](e28674b)) * check permlevel only if > 0 ([63f2cf5](63f2cf5)) * consistent fieldnames and keep port alongside server field ([c4f1619](c4f1619)) * **db:** Log mogrified queries ([ba1cdf8](ba1cdf8)) * dont init child doc ([94b760c](94b760c)) * dont pass doc to tooltip formatter on reportview ([d049c87](d049c87)) * german translations ([#17663](#17663)) ([#17771](#17771)) ([fd3eaa6](fd3eaa6)) * get correct doc when checking child table permission ([9b89dc6](9b89dc6)) * handle permlevel ([06ebd95](06ebd95)) * ignore built assets in translation ([53357e2](53357e2)) * ignore forms without docs in realtime events ([afc060f](afc060f)) * init only existing single doctypes ([75b6a33](75b6a33)) * limit allowed attributes for lazy images ([#17775](#17775)) ([1311564](1311564)) * **patch:** update multi step webform's Section Break fields to Page Break ([#17797](#17797)) ([#17798](#17798)) ([b3dc4c0](b3dc4c0)) * raise ImplicitCommitError instead of bare exception ([e2c6497](e2c6497)) * reverse logic for failing permission check ([7891674](7891674)) * **sanitize-html:** allow all data-* attrs ([9b94479](9b94479)) * send all messages on boot instead of scanning ([d61b7e8](d61b7e8)) * update append_to misleading message in email account ([#17718](#17718)) ([#17796](#17796)) ([cd86462](cd86462)) * **ux:** email domain doctype ([48c4a8d](48c4a8d)) * Webform Misc Fix (backport [#17642](#17642)) ([#17746](#17746)) ([86f9fbc](86f9fbc)) ### Features * JS extractor and custom JS parser ([fed4ae9](fed4ae9)) * **minor:** add connection link to email accounts in email domain ([821549d](821549d)) * **minor:** fetch attachment_limit from get_max_file_size api ([5190a49](5190a49)) * modified parser for frappe JS translate syntax ([0e87d21](0e87d21)) * Multilanguage sites: language selector only will show "enabled" languages and language default always will be System default ([#17745](#17745)) ([e5b8a47](e5b8a47)) * use AST to extract translation sources ([e02a73f](e02a73f)) ### Performance Improvements * reduce DB calls made in `get_fetch_values` ([#17671](#17671)) ([#17739](#17739)) ([dc19f69](dc19f69)) ### Reverts * Remove emoji from doctype ([c102124](c102124))
|
🎉 This PR is included in version 14.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #17797 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com