fix: comma looks like a decimal in report summary widget #18014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shariquerik
requested review from
a team and
surajshetty3416
and removed request for
a team
shariquerik
added
frappe-support
backport version-14-hotfix
|
Just hilarious xD |
ankush
approved these changes
Sep 2, 2022
And it has been there for 2 years. No one noticed🤣 |
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2022
[skip ci] (cherry picked from commit 7b646cc)
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2022
[skip ci] (cherry picked from commit 7b646cc)
ankush
pushed a commit
that referenced
this pull request
Sep 2, 2022
ankush
pushed a commit
that referenced
this pull request
Sep 2, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Sep 6, 2022
# [14.6.0](v14.5.0...v14.6.0) (2022-09-06) ### Bug Fixes * comma looks like a decimal in report summary widget ([#18014](#18014)) ([#18017](#18017)) ([13015c2](13015c2)) * do not remove workspaces while app is uninstalled ([434ed3d](434ed3d)) * **DX:** reduce retry count for esbuild-redis ([727adb1](727adb1)) * **patch:** only run patch if webform has is_multi_step_form field ([#17993](#17993)) ([#17994](#17994)) ([a67abbe](a67abbe)) * show unique workspaces in sidebar ([1285d84](1285d84)) * show user/pass fields when LDAP is active ([#18043](#18043)) ([2db21d5](2db21d5)) ### Features * add button to collapse all in tree view ([#17992](#17992)) ([#18003](#18003)) ([cfdc57a](cfdc57a)) * add lang to safe globals ([0293c11](0293c11)) * option to disable user pass based login ([#18000](#18000)) ([7249c17](7249c17)) * review Custom and Build workspace, move background Job to Build Workspace ([#17981](#17981)) ([#18018](#18018)) ([eaaae98](eaaae98)) ### Performance Improvements * short-circuit guest connection and basic perf tests ([#17988](#17988)) ([#17991](#17991)) ([b2d145f](b2d145f))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Sep 6, 2022
# [13.41.0](v13.40.0...v13.41.0) (2022-09-06) ### Bug Fixes * comma looks like a decimal in report summary widget ([#18014](#18014)) ([#18016](#18016)) ([af2598e](af2598e)) * **Data Import:** make warnings translatable (backport [#17924](#17924)) ([#17930](#17930)) ([1eb7248](1eb7248)) * **oauth:** Send id_token of the authorized user instead of Guest (backport [#17266](#17266)) ([#18007](#18007)) ([415f1f1](415f1f1)) ### Features * add lang to safe globals ([f51780a](f51780a))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
