feat: meaningful report pdf name #18422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #18422 +/- ##
===========================================
+ Coverage 63.15% 63.22% +0.06%
===========================================
Files 746 746
Lines 67162 67175 +13
Branches 5975 5977 +2
===========================================
+ Hits 42419 42469 +50
- Misses 21273 21275 +2
+ Partials 3470 3431 -39
Flags with carried forward coverage won't be shown. Click here to find out more. |
ankush
requested changes
Oct 16, 2022
ankush
reviewed
Oct 18, 2022
…into report-pdf-naming
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2022
* feat: meaningful report pdf name * feat: limited filename length * chore: uncomment line (cherry picked from commit f383669)
ankush
pushed a commit
that referenced
this pull request
Oct 20, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2022
* feat: meaningful report pdf name * feat: limited filename length * chore: uncomment line (cherry picked from commit f383669) # Conflicts: # frappe/public/js/frappe/microtemplate.js
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 25, 2022
# [14.13.0](v14.12.0...v14.13.0) (2022-10-25) ### Bug Fixes * consider now datetime if the default value is now for datetime field ([b42013c](b42013c)) * delete custom tables when doctype is deleted ([#18433](#18433)) ([#18471](#18471)) ([cb4d825](cb4d825)) * dont db_set on unsaved document ([798206c](798206c)) * **frappe.client:** delete child doc via parent ([8806eae](8806eae)) * google calendar sync times (system tz) ([#18458](#18458)) ([#18459](#18459)) ([871415a](871415a)) * Improve Translation on To Do list view ([#18484](#18484)) ([ddec3e0](ddec3e0)) * map view doesnt open ([#18487](#18487)) ([ed54235](ed54235)) * **minor:** consider lowercase value for comparision in set_formatted_input for datetime field ([a190830](a190830)) * only execute generator if value is not found in redis cache ([#18472](#18472)) ([#18479](#18479)) ([342edb7](342edb7)) * raise error if child doc not found ([0dcf5e6](0dcf5e6)) * validate website settings ([#18446](#18446)) ([#18469](#18469)) ([9e29a94](9e29a94)) ### Features * configurable default views ([#18409](#18409)) ([#18434](#18434)) ([5c0bb7e](5c0bb7e)) * db storage usage report ([#18464](#18464)) ([#18467](#18467)) ([7cfe2d2](7cfe2d2)) * meaningful report pdf name ([#18422](#18422)) ([#18480](#18480)) ([f650150](f650150))
ankush
pushed a commit
that referenced
this pull request
Oct 27, 2022
* feat: meaningful report pdf name * feat: limited filename length * chore: uncomment line (cherry picked from commit f383669)
ankush
pushed a commit
that referenced
this pull request
Oct 28, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
# [13.43.0](v13.42.0...v13.43.0) (2022-11-01) ### Bug Fixes * **Data Import:** don't validate empty values (backport [#17923](#17923)) ([#18274](#18274)) ([e31a8b1](e31a8b1)) * **router-js:** handle case when link is not of same host (backport [#18590](#18590)) ([#18600](#18600)) ([55e96a5](55e96a5)) ### Features * meaningful report pdf name ([#18422](#18422)) ([#18481](#18481)) ([0493ccd](0493ccd))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
Peek.2022-10-15.17-39.mp4
After:
Peek.2022-10-15.17-40.mp4
#no-docs