Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate website settings #18446

Merged
merged 1 commit into from Oct 18, 2022
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Oct 18, 2022

validate regex for route redirects

@ankush ankush requested a review from a team as a code owner October 18, 2022 06:50
@ankush ankush requested review from phot0n and removed request for a team October 18, 2022 06:50
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #18446 (f542534) into develop (ab25934) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18446      +/-   ##
===========================================
+ Coverage    63.10%   63.13%   +0.02%     
===========================================
  Files          746      746              
  Lines        67107    67162      +55     
  Branches      5975     5975              
===========================================
+ Hits         42346    42400      +54     
- Misses       21291    21292       +1     
  Partials      3470     3470              
Flag Coverage Δ
server-mariadb 67.21% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush merged commit c2f43c4 into frappe:develop Oct 18, 2022
@ankush ankush deleted the regex_validation branch October 18, 2022 07:11
@ankush ankush added the backport version-14-hotfix backport to version 14 label Oct 19, 2022
ankush added a commit that referenced this pull request Oct 19, 2022
ankush added a commit that referenced this pull request Oct 19, 2022
(cherry picked from commit c2f43c4)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Oct 25, 2022
# [14.13.0](v14.12.0...v14.13.0) (2022-10-25)

### Bug Fixes

* consider now datetime if the default value is now for datetime field ([b42013c](b42013c))
* delete custom tables when doctype is deleted ([#18433](#18433)) ([#18471](#18471)) ([cb4d825](cb4d825))
* dont db_set on unsaved document ([798206c](798206c))
* **frappe.client:** delete child doc via parent ([8806eae](8806eae))
* google calendar sync times (system tz) ([#18458](#18458)) ([#18459](#18459)) ([871415a](871415a))
* Improve Translation on To Do list view ([#18484](#18484)) ([ddec3e0](ddec3e0))
* map view doesnt open ([#18487](#18487)) ([ed54235](ed54235))
* **minor:** consider lowercase value for comparision in set_formatted_input for datetime field ([a190830](a190830))
* only execute generator if value is not found in redis cache ([#18472](#18472)) ([#18479](#18479)) ([342edb7](342edb7))
* raise error if child doc not found ([0dcf5e6](0dcf5e6))
* validate website settings ([#18446](#18446)) ([#18469](#18469)) ([9e29a94](9e29a94))

### Features

* configurable default views ([#18409](#18409)) ([#18434](#18434)) ([5c0bb7e](5c0bb7e))
* db storage usage report ([#18464](#18464)) ([#18467](#18467)) ([7cfe2d2](7cfe2d2))
* meaningful report pdf name ([#18422](#18422)) ([#18480](#18480)) ([f650150](f650150))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant