fix: Signature form #18477

DrZoidberg09 · 2022-10-19T20:10:06Z

Since version 14 the signature form is broken. This PR should fix it and bring it back to the same functionality as in version-13.

Closes: #18299
Closes: #17760
Closes: #17660

Before:

Screen.Recording.2022-10-31.at.12.25.30.PM.mov

After:

Screen.Recording.2022-10-31.at.12.08.43.PM.mov

codecov · 2022-10-20T11:45:37Z

Codecov Report

Merging #18477 (a0b2824) into develop (e564dcb) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head a0b2824 differs from pull request most recent head afd8666. Consider uploading reports for the commit afd8666 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #18477      +/-   ##
===========================================
- Coverage    63.00%   62.95%   -0.06%     
===========================================
  Files          747      749       +2     
  Lines        67794    68940    +1146     
  Branches      5996     5993       -3     
===========================================
+ Hits         42716    43403     +687     
- Misses       21618    22024     +406     
- Partials      3460     3513      +53

Flag	Coverage Δ
server-ui	`31.19% <ø> (+0.02%)`	⬆️
ui-tests	`50.08% <0.00%> (-0.13%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

ankush · 2022-10-21T04:33:43Z

@shariquerik linked issues have visuals for reference.. seems like critical problem with signature control, lets try to fix by next release?

#18299 (comment)

shariquerik

I can still see 2 issues.

If we create a new doc we cannot add a signature as it is blocked. After saving we can add.
After saving if we reload the page then the refresh icon is missing and we can no longer edit the signature field. If we reload using reload button in the menu it makes it editable again.
We should have a label for the signature field

Screen.Recording.2022-10-21.at.12.22.48.PM.mov

DrZoidberg09 · 2022-10-21T11:02:38Z

That is very strange. I use it in my timesheet doctype without any issues:

Design.ohne.Titel.mp4

Any ideas why such flaky behavior?

shariquerik · 2022-10-28T06:08:52Z

Any ideas why such flaky behavior?

No, idea, try creating fresh doctype and check if you can reproduce

DrZoidberg09 · 2022-10-29T19:18:04Z

Yes, I could reproduce it with a new DocType. Super strange.

But I think, this should finally fix it. Could you please try?

shariquerik · 2022-10-31T07:03:01Z

@DrZoidberg09 #17760 problem still exist

edit: Fixed

DrZoidberg09 · 2022-10-31T11:37:49Z

Awesome! Thank you @shariquerik

shariquerik · 2022-10-31T14:15:19Z

Unrelated test failing

Co-authored-by: Ankush Menat <ankush@frappe.io> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> (cherry picked from commit 0bc2f16)

# [14.14.0](v14.13.0...v14.14.0) (2022-11-01) ### Bug Fixes * correct stacklevel for warnings ([#18633](#18633)) ([#18634](#18634)) ([17821f1](17821f1)) * **formatting:** use snake case for variable names ([32851ce](32851ce)) * handle exceptions thrown in post_schema_updates ([#18648](#18648)) ([#18663](#18663)) ([29a659a](29a659a)) * **insert_many:** list instead of set to maintain order ([#18641](#18641)) ([4c521b8](4c521b8)) * make module def custom checkbox readonly in prod mode ([#18698](#18698)) ([18fa732](18fa732)) * **router-js:** handle case when link is not of same host ([1b70ec4](1b70ec4)) * set proper cache key for singles when name is passed as `None` ([#18667](#18667)) ([#18668](#18668)) ([e32ba96](e32ba96)) * Signature form ([#18477](#18477)) ([8e4711b](8e4711b)) * Signature form (backport [#18477](#18477)) ([#18690](#18690)) ([34c1611](34c1611)) * support symlinked /files directory ([#18702](#18702)) ([7b8cbd0](7b8cbd0)) * use `async...await` when parsing route ([9c09c65](9c09c65)) * use `is_file_path_valid` instead of `is_safe_path` ([#18316](#18316)) ([#18642](#18642)) ([537966c](537966c)) * **UX:** Info message on workspace for better UX (backport [#18701](#18701)) ([#18703](#18703)) ([5ba85ec](5ba85ec)) * **UX:** session expiry explanation and defaults ([#18680](#18680)) ([#18685](#18685)) ([515f6c2](515f6c2)) * **UX:** warn about Etc/* timezones behaviour ([#18587](#18587)) ([#18588](#18588)) ([c8728f5](c8728f5)) * webform validation script not working ([ab2b8df](ab2b8df)) ### Features * add video conferencing option (Google Meet) to Google Calendar integration (backport [#17851](#17851)) ([#18456](#18456)) ([b04a54c](b04a54c)) * support list view for "show titles instead of name" ([#18060](#18060)) ([#18681](#18681)) ([64c2555](64c2555)) ### Performance Improvements * ensure cache works for `non_standard_user_types` when empty ([#18665](#18665)) ([#18669](#18669)) ([5f7928b](5f7928b)) ### Reverts * Revert "fix: use `is_file_path_valid` instead of `is_safe_path` (#18316) (#18642)" (#18696) ([a08c029](a08c029)), closes [#18316](#18316) [#18642](#18642) [#18696](#18696)

Co-authored-by: Ankush Menat <ankush@frappe.io> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com> Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> (cherry picked from commit 0bc2f16)

# [14.14.0](frappe/frappe@v14.13.0...v14.14.0) (2022-11-01) ### Bug Fixes * correct stacklevel for warnings ([frappe#18633](frappe#18633)) ([frappe#18634](frappe#18634)) ([17821f1](frappe@17821f1)) * **formatting:** use snake case for variable names ([32851ce](frappe@32851ce)) * handle exceptions thrown in post_schema_updates ([frappe#18648](frappe#18648)) ([frappe#18663](frappe#18663)) ([29a659a](frappe@29a659a)) * **insert_many:** list instead of set to maintain order ([frappe#18641](frappe#18641)) ([4c521b8](frappe@4c521b8)) * make module def custom checkbox readonly in prod mode ([frappe#18698](frappe#18698)) ([18fa732](frappe@18fa732)) * **router-js:** handle case when link is not of same host ([1b70ec4](frappe@1b70ec4)) * set proper cache key for singles when name is passed as `None` ([frappe#18667](frappe#18667)) ([frappe#18668](frappe#18668)) ([e32ba96](frappe@e32ba96)) * Signature form ([frappe#18477](frappe#18477)) ([8e4711b](frappe@8e4711b)) * Signature form (backport [frappe#18477](frappe#18477)) ([frappe#18690](frappe#18690)) ([34c1611](frappe@34c1611)) * support symlinked /files directory ([frappe#18702](frappe#18702)) ([7b8cbd0](frappe@7b8cbd0)) * use `async...await` when parsing route ([9c09c65](frappe@9c09c65)) * use `is_file_path_valid` instead of `is_safe_path` ([frappe#18316](frappe#18316)) ([frappe#18642](frappe#18642)) ([537966c](frappe@537966c)) * **UX:** Info message on workspace for better UX (backport [frappe#18701](frappe#18701)) ([frappe#18703](frappe#18703)) ([5ba85ec](frappe@5ba85ec)) * **UX:** session expiry explanation and defaults ([frappe#18680](frappe#18680)) ([frappe#18685](frappe#18685)) ([515f6c2](frappe@515f6c2)) * **UX:** warn about Etc/* timezones behaviour ([frappe#18587](frappe#18587)) ([frappe#18588](frappe#18588)) ([c8728f5](frappe@c8728f5)) * webform validation script not working ([ab2b8df](frappe@ab2b8df)) ### Features * add video conferencing option (Google Meet) to Google Calendar integration (backport [frappe#17851](frappe#17851)) ([frappe#18456](frappe#18456)) ([b04a54c](frappe@b04a54c)) * support list view for "show titles instead of name" ([frappe#18060](frappe#18060)) ([frappe#18681](frappe#18681)) ([64c2555](frappe@64c2555)) ### Performance Improvements * ensure cache works for `non_standard_user_types` when empty ([frappe#18665](frappe#18665)) ([frappe#18669](frappe#18669)) ([5f7928b](frappe@5f7928b)) ### Reverts * Revert "fix: use `is_file_path_valid` instead of `is_safe_path` (frappe#18316) (frappe#18642)" (frappe#18696) ([a08c029](frappe@a08c029)), closes [frappe#18316](frappe#18316) [frappe#18642](frappe#18642) [frappe#18696](frappe#18696)

Update signature.js

4bfd59d

DrZoidberg09 requested a review from a team as a code owner October 19, 2022 20:10

DrZoidberg09 requested review from shariquerik and removed request for a team October 19, 2022 20:10

ankush assigned shariquerik Oct 20, 2022

style: prettier

a0b2824

ankush added the squash label Oct 20, 2022

shariquerik added the add-visuals add before and after images/ gifs to describe the fix/ feature label Oct 20, 2022

shariquerik requested changes Oct 21, 2022

View reviewed changes

codrotech mentioned this pull request Oct 27, 2022

Erpnext 14 Signature Field Issue frappe/erpnext#32701

Closed

Update signature.js

926c46e

ankush and others added 2 commits October 30, 2022 11:22

Merge branch 'develop' into patch-3

fc7de05

fix: show label for signature field

17811a0

shariquerik removed the add-visuals add before and after images/ gifs to describe the fix/ feature label Oct 31, 2022

Merge branch 'develop' into patch-3

2329b58

ankush added the backport version-14-hotfix backport to version 14 label Oct 31, 2022

fix: signature is broken if in different tab

afd8666

shariquerik merged commit 0bc2f16 into frappe:develop Oct 31, 2022

mergify bot mentioned this pull request Oct 31, 2022

fix: Signature form (backport #18477) #18690

Merged

shariquerik added a commit that referenced this pull request Oct 31, 2022

fix: Signature form (backport #18477) (#18690)

34c1611

github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Signature form #18477

fix: Signature form #18477

DrZoidberg09 commented Oct 19, 2022 •

edited by shariquerik

codecov bot commented Oct 20, 2022 •

edited

ankush commented Oct 21, 2022 •

edited

shariquerik left a comment •

edited

DrZoidberg09 commented Oct 21, 2022

shariquerik commented Oct 28, 2022

DrZoidberg09 commented Oct 29, 2022

shariquerik commented Oct 31, 2022 •

edited

DrZoidberg09 commented Oct 31, 2022

shariquerik commented Oct 31, 2022

fix: Signature form #18477

fix: Signature form #18477

Conversation

DrZoidberg09 commented Oct 19, 2022 • edited by shariquerik

codecov bot commented Oct 20, 2022 • edited

Codecov Report

ankush commented Oct 21, 2022 • edited

shariquerik left a comment • edited

Choose a reason for hiding this comment

DrZoidberg09 commented Oct 21, 2022

shariquerik commented Oct 28, 2022

DrZoidberg09 commented Oct 29, 2022

shariquerik commented Oct 31, 2022 • edited

DrZoidberg09 commented Oct 31, 2022

shariquerik commented Oct 31, 2022

DrZoidberg09 commented Oct 19, 2022 •

edited by shariquerik

codecov bot commented Oct 20, 2022 •

edited

ankush commented Oct 21, 2022 •

edited

shariquerik left a comment •

edited

shariquerik commented Oct 31, 2022 •

edited