New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: z-index for barcode and awesomeplete #18893
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maharshivpatel
requested review from
phot0n and
shariquerik
and removed request for
a team
November 16, 2022 07:35
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #18893 +/- ##
===========================================
- Coverage 63.47% 62.97% -0.50%
===========================================
Files 750 750
Lines 67551 68453 +902
Branches 6018 6029 +11
===========================================
+ Hits 42877 43111 +234
- Misses 21223 21879 +656
- Partials 3451 3463 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
shariquerik
added
the
defer backport
Backports for some PR are deferred for a week or two to test them properly before releasing
label
Nov 18, 2022
maharshivpatel
added a commit
to maharshivpatel/frappe
that referenced
this pull request
Nov 18, 2022
required after changes in frappe#18893
shariquerik
approved these changes
Nov 19, 2022
ankush
added
backport version-14-hotfix
backport to version 14
and removed
defer backport
Backports for some PR are deferred for a week or two to test them properly before releasing
labels
Nov 25, 2022
ankush
pushed a commit
that referenced
this pull request
Nov 25, 2022
* fix: z-index for barcode and awesomeplete (cherry picked from commit 88e331e) * fix: update z-index (cherry picked from commit 799e22a) * revert: unused css (cherry picked from commit aa3794a) * fix: update z-index considering sticky tabs (cherry picked from commit 9bbac0f) Co-authored-by: Maharshi Patel <maharshi.patel988@gmail.com> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
# [14.17.0](v14.16.0...v14.17.0) (2022-11-29) ### Bug Fixes * Avoid `update_order` twice on Kanban load ([#19011](#19011)) ([#19013](#19013)) ([c6e2d16](c6e2d16)) * broken link for email tracking pixels ([#19030](#19030)) ([#19032](#19032)) ([ca520e0](ca520e0)) * Correctness in get_role_permissions and has_perm JS APIs (backport [#18877](#18877)) ([#18976](#18976)) ([cc2cd5f](cc2cd5f)) * default value options: sort ([#19019](#19019)) ([#19022](#19022)) ([3ec6d9c](3ec6d9c)) * discovery and styling issues in grid buttons ([a6bda7f](a6bda7f)) * handle "No Letterhead" in new print format builder ([#18990](#18990)) ([#18992](#18992)) ([1ad1cab](1ad1cab)) * horizontal scroll in rtl language ([906336e](906336e)) * only accept string values for `key` ([237a152](237a152)) * webform read only field not working ([#19026](#19026)) ([ce505ca](ce505ca)) * z-index for barcode and awesomeplete (backport [#18893](#18893)) ([#19003](#19003)) ([0191858](0191858)) ### Features * add param letterhead to frappe.get_print ([#18989](#18989)) ([#19034](#19034)) ([c887be5](c887be5))
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Nov 30, 2022
…appe#19003) * fix: z-index for barcode and awesomeplete (cherry picked from commit 88e331e) * fix: update z-index (cherry picked from commit 799e22a) * revert: unused css (cherry picked from commit aa3794a) * fix: update z-index considering sticky tabs (cherry picked from commit 9bbac0f) Co-authored-by: Maharshi Patel <maharshi.patel988@gmail.com> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Nov 30, 2022
# [14.17.0](frappe/frappe@v14.16.0...v14.17.0) (2022-11-29) ### Bug Fixes * Avoid `update_order` twice on Kanban load ([frappe#19011](frappe#19011)) ([frappe#19013](frappe#19013)) ([c6e2d16](frappe@c6e2d16)) * broken link for email tracking pixels ([frappe#19030](frappe#19030)) ([frappe#19032](frappe#19032)) ([ca520e0](frappe@ca520e0)) * Correctness in get_role_permissions and has_perm JS APIs (backport [frappe#18877](frappe#18877)) ([frappe#18976](frappe#18976)) ([cc2cd5f](frappe@cc2cd5f)) * default value options: sort ([frappe#19019](frappe#19019)) ([frappe#19022](frappe#19022)) ([3ec6d9c](frappe@3ec6d9c)) * discovery and styling issues in grid buttons ([a6bda7f](frappe@a6bda7f)) * handle "No Letterhead" in new print format builder ([frappe#18990](frappe#18990)) ([frappe#18992](frappe#18992)) ([1ad1cab](frappe@1ad1cab)) * horizontal scroll in rtl language ([906336e](frappe@906336e)) * only accept string values for `key` ([237a152](frappe@237a152)) * webform read only field not working ([frappe#19026](frappe#19026)) ([ce505ca](frappe@ce505ca)) * z-index for barcode and awesomeplete (backport [frappe#18893](frappe#18893)) ([frappe#19003](frappe#19003)) ([0191858](frappe@0191858)) ### Features * add param letterhead to frappe.get_print ([frappe#18989](frappe#18989)) ([frappe#19034](frappe#19034)) ([c887be5](frappe@c887be5))
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Dec 1, 2022
…appe#19003) * fix: z-index for barcode and awesomeplete (cherry picked from commit 88e331e) * fix: update z-index (cherry picked from commit 799e22a) * revert: unused css (cherry picked from commit aa3794a) * fix: update z-index considering sticky tabs (cherry picked from commit 9bbac0f) Co-authored-by: Maharshi Patel <maharshi.patel988@gmail.com> Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Dec 1, 2022
# [14.17.0](frappe/frappe@v14.16.0...v14.17.0) (2022-11-29) ### Bug Fixes * Avoid `update_order` twice on Kanban load ([frappe#19011](frappe#19011)) ([frappe#19013](frappe#19013)) ([c6e2d16](frappe@c6e2d16)) * broken link for email tracking pixels ([frappe#19030](frappe#19030)) ([frappe#19032](frappe#19032)) ([ca520e0](frappe@ca520e0)) * Correctness in get_role_permissions and has_perm JS APIs (backport [frappe#18877](frappe#18877)) ([frappe#18976](frappe#18976)) ([cc2cd5f](frappe@cc2cd5f)) * default value options: sort ([frappe#19019](frappe#19019)) ([frappe#19022](frappe#19022)) ([3ec6d9c](frappe@3ec6d9c)) * discovery and styling issues in grid buttons ([a6bda7f](frappe@a6bda7f)) * handle "No Letterhead" in new print format builder ([frappe#18990](frappe#18990)) ([frappe#18992](frappe#18992)) ([1ad1cab](frappe@1ad1cab)) * horizontal scroll in rtl language ([906336e](frappe@906336e)) * only accept string values for `key` ([237a152](frappe@237a152)) * webform read only field not working ([frappe#19026](frappe#19026)) ([ce505ca](frappe@ce505ca)) * z-index for barcode and awesomeplete (backport [frappe#18893](frappe#18893)) ([frappe#19003](frappe#19003)) ([0191858](frappe@0191858)) ### Features * add param letterhead to frappe.get_print ([frappe#18989](frappe#18989)) ([frappe#19034](frappe#19034)) ([c887be5](frappe@c887be5))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have changed scan button's
z-index: 1;
and awesomeplete'sz-index: 2;
Barcode scan button:
Awesomeplete:
This fixes #18811