fix(socketio): Event list_update > doctype_subscribe #19422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavindsouza
added
backport version-13-hotfix
backport version-14-hotfix
github-actions
bot
added
the
add-test-cases
gavindsouza
removed
the
add-test-cases
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #19422 +/- ##
===========================================
- Coverage 65.13% 65.04% -0.09%
===========================================
Files 755 755
Lines 71929 71929
Branches 6119 6119
===========================================
- Hits 46852 46789 -63
- Misses 21612 21615 +3
- Partials 3465 3525 +60
Flags with carried forward coverage won't be shown. Click here to find out more. |
phot0n
approved these changes
Dec 29, 2022
This was referenced Dec 29, 2022
phot0n
pushed a commit
that referenced
this pull request
Dec 29, 2022
phot0n
pushed a commit
that referenced
this pull request
Dec 29, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 4, 2023
## [13.46.3](v13.46.2...v13.46.3) (2023-01-04) ### Bug Fixes * only allow system manager to create/edit email templates by default (backport [#19458](#19458)) ([4dedbd8](4dedbd8)) * prevent emails from being queued multiple times ([#19386](#19386)) ([#19453](#19453)) ([4b1ad20](4b1ad20)) * **socketio:** Event list_update > doctype_subscribe (backport [#19422](#19422)) ([#19431](#19431)) ([1a2a1cc](1a2a1cc))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 4, 2023
## [14.21.1](v14.21.0...v14.21.1) (2023-01-04) ### Bug Fixes * Allow everyone to read geo data ([#19451](#19451)) ([#19457](#19457)) ([54eecce](54eecce)) * build_response for re.Match ([#19442](#19442)) ([c3729c7](c3729c7)) * don't set default in list view for fields not allowed ([373234d](373234d)) * **link/js:** handle undefined `link_title_doctypes` in `frappe.boot` ([#19398](#19398)) ([#19402](#19402)) ([f314e58](f314e58)) * only allow system manager to create email templates ([f46a649](f46a649)) * prevent emails from being queued multiple times ([#19386](#19386)) ([#19454](#19454)) ([21b84a4](21b84a4)) * show document title instead of name in like notification email subject ([41af70d](41af70d)) * **socketio:** Event list_update > doctype_subscribe (backport [#19422](#19422)) ([#19432](#19432)) ([4529e6d](4529e6d)) * **test:** override fields of test doctype if passed ([8a86a8c](8a86a8c)) * use title instead of name in message body too ([5878b53](5878b53))
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Jan 10, 2023
…#19422) (frappe#19432) * fix(socketio)!: Event list_update > doctype_subscribe (cherry picked from commit c960382) # Conflicts: # frappe/realtime.py * chore: resolve conflict Co-authored-by: Gavin D'souza <gavin18d@gmail.com>
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Jan 10, 2023
## [14.21.1](frappe/frappe@v14.21.0...v14.21.1) (2023-01-04) ### Bug Fixes * Allow everyone to read geo data ([frappe#19451](frappe#19451)) ([frappe#19457](frappe#19457)) ([54eecce](frappe@54eecce)) * build_response for re.Match ([frappe#19442](frappe#19442)) ([c3729c7](frappe@c3729c7)) * don't set default in list view for fields not allowed ([373234d](frappe@373234d)) * **link/js:** handle undefined `link_title_doctypes` in `frappe.boot` ([frappe#19398](frappe#19398)) ([frappe#19402](frappe#19402)) ([f314e58](frappe@f314e58)) * only allow system manager to create email templates ([f46a649](frappe@f46a649)) * prevent emails from being queued multiple times ([frappe#19386](frappe#19386)) ([frappe#19454](frappe#19454)) ([21b84a4](frappe@21b84a4)) * show document title instead of name in like notification email subject ([41af70d](frappe@41af70d)) * **socketio:** Event list_update > doctype_subscribe (backport [frappe#19422](frappe#19422)) ([frappe#19432](frappe#19432)) ([4529e6d](frappe@4529e6d)) * **test:** override fields of test doctype if passed ([8a86a8c](frappe@8a86a8c)) * use title instead of name in message body too ([5878b53](frappe@5878b53))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed internal methods (added via #18875) to subscribe to doctype list updates, the underlying event & API for consistency