fix: correct exit code on missing app failure #19676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
add-test-cases
ankush
force-pushed
the
missing_app_exit
branch
from
87e43a7
to
d7feb44
Compare
|
TODO: Audit usage for catch-all exception handling. (done, nothing critical) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #19676 +/- ##
========================================
Coverage 62.92% 62.92%
========================================
Files 754 754
Lines 70638 70617 -21
Branches 6134 6134
========================================
- Hits 44448 44437 -11
+ Misses 22714 22704 -10
Partials 3476 3476
Flags with carried forward coverage won't be shown. Click here to find out more. |
ankush
added
defer backport
mergify bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
(cherry picked from commit 0449f85) # Conflicts: # frappe/__init__.py
mergify bot
pushed a commit
that referenced
this pull request
Jan 25, 2023
(cherry picked from commit 0449f85)
ankush
added a commit
that referenced
this pull request
Jan 25, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 30, 2023
# [14.25.0](v14.24.0...v14.25.0) (2023-01-30) ### Bug Fixes * add freeze message for bulk delete ([2a42036](2a42036)) * assertAlmostEqual with precision ([#19794](#19794)) ([9f7c4e0](9f7c4e0)) * Convert doctype name to string ([#19832](#19832)) ([#19834](#19834)) ([a45f31d](a45f31d)) * correct exit code on missing app failure ([#19676](#19676)) ([#19770](#19770)) ([f6139a4](f6139a4)) * **i18n:** Datepicker Turkish translations ([#19777](#19777)) ([#19831](#19831)) ([3e91fb1](3e91fb1)) * incorrect link when std field has problem (backport [#19744](#19744)) ([#19763](#19763)) ([4593bb9](4593bb9)) * **MariaDBTable:** dont attempt to drop index twice ([#19783](#19783)) ([67f80c6](67f80c6)) * Password strength check for long passwords (backport [#19756](#19756)) ([#19765](#19765)) ([a6315f9](a6315f9)) * respect disable sidebar stats on list view ([#19795](#19795)) ([5f57816](5f57816)) * sanitize traceback for common secrets ([#19805](#19805)) ([#19806](#19806)) ([ae6f2b1](ae6f2b1)) * use count instead of concatenated docnames ([06948d1](06948d1)) ### Features * Audit hooks report (backport [#19780](#19780)) ([#19828](#19828)) ([99bdf34](99bdf34)) * better freeze message ([c03f9e7](c03f9e7))
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Feb 7, 2023
# [14.25.0](frappe/frappe@v14.24.0...v14.25.0) (2023-01-30) ### Bug Fixes * add freeze message for bulk delete ([2a42036](frappe@2a42036)) * assertAlmostEqual with precision ([frappe#19794](frappe#19794)) ([9f7c4e0](frappe@9f7c4e0)) * Convert doctype name to string ([frappe#19832](frappe#19832)) ([frappe#19834](frappe#19834)) ([a45f31d](frappe@a45f31d)) * correct exit code on missing app failure ([frappe#19676](frappe#19676)) ([frappe#19770](frappe#19770)) ([f6139a4](frappe@f6139a4)) * **i18n:** Datepicker Turkish translations ([frappe#19777](frappe#19777)) ([frappe#19831](frappe#19831)) ([3e91fb1](frappe@3e91fb1)) * incorrect link when std field has problem (backport [frappe#19744](frappe#19744)) ([frappe#19763](frappe#19763)) ([4593bb9](frappe@4593bb9)) * **MariaDBTable:** dont attempt to drop index twice ([frappe#19783](frappe#19783)) ([67f80c6](frappe@67f80c6)) * Password strength check for long passwords (backport [frappe#19756](frappe#19756)) ([frappe#19765](frappe#19765)) ([a6315f9](frappe@a6315f9)) * respect disable sidebar stats on list view ([frappe#19795](frappe#19795)) ([5f57816](frappe@5f57816)) * sanitize traceback for common secrets ([frappe#19805](frappe#19805)) ([frappe#19806](frappe#19806)) ([ae6f2b1](frappe@ae6f2b1)) * use count instead of concatenated docnames ([06948d1](frappe@06948d1)) ### Features * Audit hooks report (backport [frappe#19780](frappe#19780)) ([frappe#19828](frappe#19828)) ([99bdf34](frappe@99bdf34)) * better freeze message ([c03f9e7](frappe@c03f9e7))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit code should be 1 to indicate that command failed, just raising exception back should do the job, idk why explicit SystemExit is required here? 🤔