feat: let users modify hook resolution order (backport #19653) #19774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Since hook resolution depends on the order in which apps were installed on site, it should be made configurable as escape hatch in case a different resolution order is desired. Keep in mind that changing order affects every hook, page, customization so you can't pick and choose priority for individual hooks as of now. Separate proposals are welcome for such configurabilty. (cherry picked from commit 1796cae) # Conflicts: # frappe/core/doctype/installed_applications/installed_applications.js # frappe/core/doctype/installed_applications/test_installed_applications.py
(cherry picked from commit c14379c)
[skip ci] Co-Authored-By: Suraj Shetty <surajshetty3416@gmail.com> Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 30, 2023
# [13.49.0](v13.48.0...v13.49.0) (2023-01-30) ### Bug Fixes * add freeze message for bulk delete ([486df4c](486df4c)) * **i18n:** Datepicker Turkish translations ([#19777](#19777)) ([#19830](#19830)) ([5ba34b4](5ba34b4)) * incorrect link when std field has problem (backport [#19744](#19744)) ([#19764](#19764)) ([30729a2](30729a2)) * **MariaDBTable:** dont attempt to drop index twice ([#19783](#19783)) ([#19801](#19801)) ([1b94c62](1b94c62)) * use count instead of concatenated docnames ([d8d7373](d8d7373)) ### Features * Audit hooks report (backport [#19780](#19780)) ([#19827](#19827)) ([361e250](361e250)) * better freeze message ([7f46807](7f46807)) * let users modify hook resolution order (backport [#19653](#19653)) ([#19774](#19774)) ([76e0974](76e0974)), closes [#19672](#19672)
|
🎉 This PR is included in version 13.49.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #19653 done by Mergify.
Cherry-pick of 1796cae has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com