fix: currency formatter got incorrect format when use precision 0 #21239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gn306029
changed the title
gn306029
changed the title
ankush
changed the title
…on 0" This reverts commit 1919cf4.
ankush
reviewed
Jun 5, 2023
ankush
approved these changes
Jun 5, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
…1239) * fix: currency formatter got incorrect format when use precision 0 * Revert "fix: currency formatter got incorrect format when use precision 0" This reverts commit 1919cf4. * fix: allow 0 as default precision --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 54fabab)
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2023
…1239) * fix: currency formatter got incorrect format when use precision 0 * Revert "fix: currency formatter got incorrect format when use precision 0" This reverts commit 1919cf4. * fix: allow 0 as default precision --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 54fabab) # Conflicts: # frappe/public/js/frappe/form/formatters.js
ankush
pushed a commit
that referenced
this pull request
Jun 5, 2023
…1239) (#21240) * fix: currency formatter got incorrect format when use precision 0 * Revert "fix: currency formatter got incorrect format when use precision 0" This reverts commit 1919cf4. * fix: allow 0 as default precision --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 54fabab) Co-authored-by: gn306029 <gn306029@users.noreply.github.com>
ankush
added a commit
that referenced
this pull request
Jun 5, 2023
…ckport #21239) (#21241) * fix: currency formatter got incorrect format when use precision 0 (#21239) * fix: currency formatter got incorrect format when use precision 0 * Revert "fix: currency formatter got incorrect format when use precision 0" This reverts commit 1919cf4. * fix: allow 0 as default precision --------- Co-authored-by: Ankush Menat <ankush@frappe.io> (cherry picked from commit 54fabab) # Conflicts: # frappe/public/js/frappe/form/formatters.js * Revert "fix: currency formatter got incorrect format when use precision 0 (#21239)" This reverts commit 1d54c5d. * fix: allow setting 0 as precision in formatter --------- Co-authored-by: gn306029 <gn306029@users.noreply.github.com> Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
## [13.56.7](v13.56.6...v13.56.7) (2023-06-06) ### Bug Fixes * correct index syncing (backport [#18262](#18262)) ([#20841](#20841)) ([6d69c05](6d69c05)) * currency formatter got incorrect format when use precision 0 (backport [#21239](#21239)) ([#21241](#21241)) ([fc48bda](fc48bda)) * Resolve conflicts ([0b91838](0b91838)) * **safe_eval:** Normalize code passed before validating the code ([7effffa](7effffa))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
# [14.38.0](v14.37.1...v14.38.0) (2023-06-06) ### Bug Fixes * changed for section with features and testimonial web temlates ([9bc5c37](9bc5c37)) * changed section with card url field to small text ([1815103](1815103)) * Check if signature already exist ([6463dab](6463dab)) * currency formatter got incorrect format when use precision 0 ([#21239](#21239)) ([#21240](#21240)) ([6e5248a](6e5248a)) * declare the function ([#21261](#21261)) ([#21262](#21262)) ([9a68696](9a68696)) * do not render custom cards if workspace does not contain content ([795c894](795c894)) * doctype name localization ([#21197](#21197)) ([#21200](#21200)) ([62f25f7](62f25f7)) * fit and recenter map when section is expanded ([5d2a3ab](5d2a3ab)) * form tour set parent tab active. ([#21163](#21163)) ([#21184](#21184)) ([ae09cf9](ae09cf9)) * handle multiple webform for same doctype ([5243143](5243143)) * handle read only property ([a0e2c28](a0e2c28)) * Load map libraries at build time to avoid async issues during geolocation render ([d287dc9](d287dc9)) * Load map libraries at build time to avoid async issues during geolocation render ([e128c9d](e128c9d)) * **role:** Set desk properties (e.g. search_bar) to 1 for roles with desk access ([#21162](#21162)) ([#21231](#21231)) ([23ce3a0](23ce3a0)) * **safe_eval:** Normalize code passed before validating the code ([e58b721](e58b721)) * ui tour popover when outside viewport ([#21164](#21164)) ([#21205](#21205)) ([c3dc409](c3dc409)) * **UX:** Notify if newly created user has no roles ([#21251](#21251)) ([#21254](#21254)) ([e203bc1](e203bc1)) * **ux:** re routes based on setup_complete ([#21118](#21118)) ([#21185](#21185)) ([5e425e2](5e425e2)) ### Features * formatter for `Attach` and `Attach Image` fields ([92659ca](92659ca)) * log all DDL queries ([#21107](#21107)) ([a693c6d](a693c6d)) * read-only geolocation (GDE-86) ([bf24d87](bf24d87)) * used cached version of document in mapper ([#21186](#21186)) ([#21189](#21189)) ([7f46640](7f46640))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21236