Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard Charts: no permission for child doctype charts #26010

Open
casesolved-co-uk opened this issue Apr 17, 2024 · 0 comments
Open

Dashboard Charts: no permission for child doctype charts #26010

casesolved-co-uk opened this issue Apr 17, 2024 · 0 comments
Labels
bug

Comments

@casesolved-co-uk
Copy link
Contributor

casesolved-co-uk commented Apr 17, 2024 •
edited

When Dashboard Charts are based on a child table, the permissions code will always deny permission according to this line:

frappe/frappe/desk/doctype/dashboard_chart/dashboard_chart.py

Line 83 in cab3b96

if doc.document_type in allowed_doctypes:

Only valid for 'normal' users (not Administrator or a System Manager)
This was referenced Apr 17, 2024
Closed
Closed
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue Apr 18, 2024
@casesolved-co-uk
fix: Dashboard Chart permissions and caching, fixes: frappe#26023 and f…
a220dc5 
…rappe#26020

chore: disable semgrep
chore: formatting
chore: formatting
chore: formatting
chore: formatting
feat: add permissions test case
chore: formatting
chore: formatting
fix: the actual bug! frappe#26010
fix: typos in test
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue Apr 18, 2024
@casesolved-co-uk
fix: Dashboard Chart permissions and caching, fixes: frappe#26023 and f…
c6f7d42 
…rappe#26020

chore: disable semgrep
chore: formatting
chore: formatting
chore: formatting
chore: formatting
feat: add permissions test case
chore: formatting
chore: formatting
fix: the actual bug! frappe#26010
fix: typos in test
fix: test typo
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue Apr 18, 2024
@casesolved-co-uk
fix: Dashboard Chart permissions and caching, fixes: frappe#26023 and f…
f58ba0d 
…rappe#26020

chore: disable semgrep
chore: formatting
chore: formatting
chore: formatting
chore: formatting
feat: add permissions test case
chore: formatting
chore: formatting
fix: the actual bug! frappe#26010
fix: typos in test
fix: test typo
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue May 7, 2024
@casesolved-co-uk
fix: Dashboard Chart permissions and caching, fixes: frappe#26023 and f…
7d2a2a4 
…rappe#26020

chore: disable semgrep
chore: formatting
chore: formatting
chore: formatting
chore: formatting
feat: add permissions test case
chore: formatting
chore: formatting
fix: the actual bug! frappe#26010
fix: typos in test
fix: test typo
fix: chart permissions caching and roles and test chart delete
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue May 7, 2024
@casesolved-co-uk
fix: Dashboard Chart permissions and caching, fixes: frappe#26023 and f…
3814dfb 
…rappe#26020

chore: disable semgrep
chore: formatting
chore: formatting
chore: formatting
chore: formatting
feat: add permissions test case
chore: formatting
chore: formatting
fix: the actual bug! frappe#26010
fix: typos in test
fix: test typo
fix: chart permissions caching and roles and test chart delete
fix: role db escape
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue May 7, 2024
@casesolved-co-uk
fix: Dashboard Chart permissions and caching, fixes: frappe#26023 and f…
e2d7337 
…rappe#26020

chore: disable semgrep
chore: formatting
chore: formatting
chore: formatting
chore: formatting
feat: add permissions test case
chore: formatting
chore: formatting
fix: the actual bug! frappe#26010
fix: typos in test
fix: test typo
fix: chart permissions caching and roles and test chart delete
fix: role db escape
fix: normalise sql
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue May 7, 2024
@casesolved-co-uk
fix: Dashboard Chart permissions and caching, fixes: frappe#26023 and f…
4a318aa 
…rappe#26020

chore: disable semgrep
chore: formatting
chore: formatting
chore: formatting
chore: formatting
feat: add permissions test case
chore: formatting
chore: formatting
fix: the actual bug! frappe#26010
fix: typos in test
fix: test typo
fix: chart permissions caching and roles and test chart delete
fix: role db escape
fix: normalise sql
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue May 7, 2024
@casesolved-co-uk
fix: Dashboard Chart permissions and caching, fixes: frappe#26023 and f…
4cb3a11 
…rappe#26020

chore: disable semgrep
chore: formatting
chore: formatting
chore: formatting
chore: formatting
feat: add permissions test case
chore: formatting
chore: formatting
fix: the actual bug! frappe#26010
fix: typos in test
fix: test typo
fix: chart permissions caching and roles and test chart delete
fix: role db escape
fix: normalise sql
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue May 7, 2024
@casesolved-co-uk
fix: Dashboard Chart permissions and caching, fixes: frappe#26023 and f…
6b97ff3 
…rappe#26020

chore: disable semgrep
chore: formatting
chore: formatting
chore: formatting
chore: formatting
feat: add permissions test case
chore: formatting
chore: formatting
fix: the actual bug! frappe#26010
fix: typos in test
fix: test typo
fix: chart permissions caching and roles and test chart delete
fix: role db escape
fix: normalise sql
fix: db query has no child tables
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue May 7, 2024
@casesolved-co-uk
fix: Dashboard Chart permissions and caching, fixes: frappe#26023 and f…
9e93c35 
…rappe#26020

chore: disable semgrep
chore: formatting
chore: formatting
chore: formatting
chore: formatting
feat: add permissions test case
chore: formatting
chore: formatting
fix: the actual bug! frappe#26010
fix: typos in test
fix: test typo
fix: chart permissions caching and roles and test chart delete
fix: role db escape
fix: normalise sql
fix: db query has no child tables
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue May 7, 2024
@casesolved-co-uk
fix: Dashboard Chart permissions and caching, fixes: frappe#26023 and f…
cabe336 
…rappe#26020

chore: disable semgrep
chore: formatting
chore: formatting
chore: formatting
chore: formatting
feat: add permissions test case
chore: formatting
chore: formatting
fix: the actual bug! frappe#26010
fix: typos in test
fix: test typo
fix: chart permissions caching and roles and test chart delete
fix: role db escape
fix: normalise sql
fix: db query has no child tables
casesolved-co-uk added a commit to CaseSolvedUK/frappe that referenced this issue May 7, 2024
@casesolved-co-uk
fix: Dashboard Chart permissions and caching, fixes: frappe#26023 and f…
853a845 
…rappe#26020

chore: disable semgrep
chore: formatting
chore: formatting
chore: formatting
chore: formatting
feat: add permissions test case
chore: formatting
chore: formatting
fix: the actual bug! frappe#26010
fix: typos in test
fix: test typo
fix: chart permissions caching and roles and test chart delete
fix: role db escape
fix: normalise sql
fix: db query has no child tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@casesolved-co-uk