Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations to the Calendar view #2783

Closed
mnatalia opened this issue Feb 28, 2017 · 14 comments
Closed

Add translations to the Calendar view #2783

mnatalia opened this issue Feb 28, 2017 · 14 comments

Comments

@mnatalia
Copy link
Contributor

I tried to add translations to the Calendar view. But seems it doesn't work.
screenshot from 2017-02-28 13 53 18

@mhbu50
Copy link
Contributor

mhbu50 commented Mar 14, 2017

+1

@GSLabIt
Copy link

GSLabIt commented Mar 22, 2017

Sent a pull request for Calendar localization:

#2894

@GSLabIt
Copy link

GSLabIt commented Mar 30, 2017

Fixed by #2963

@mnatalia
Copy link
Contributor Author

@joezsweet I've updated my local setup and I have

ERPNext: v8.0.0 (master)
Frappe Framework: v8.0.0 (master)

do if I use English as user's language my week starts from Sunday if I use other language it starts from Monday, right?

@GSLabIt
Copy link

GSLabIt commented Mar 30, 2017

It depends on the language. i.e. en-US starts on Sunday, en-GB starts on monday, italian starts on Monday

@mnatalia
Copy link
Contributor Author

@joezsweet but it seems it doesn't work, in ERP we have en as I think is en-GB and en-US but in both cases week starts from Sunday

@GSLabIt
Copy link

GSLabIt commented Mar 30, 2017

@mnatalia fullcalendar and datepicker use "en" value in different way. I sent a new pull request to fix it. Have a look at #2981

@GSLabIt
Copy link

GSLabIt commented Apr 10, 2017

@mnatalia it should be fixed on last update in develop branch, please pull and check

@mnatalia
Copy link
Contributor Author

@joezsweet hi, thanks it works

@GSLabIt
Copy link

GSLabIt commented Apr 11, 2017

@mnatalia 👍 can you close the issue, thx

@mnatalia
Copy link
Contributor Author

@joezsweet maybe you can give me some advice how can I make Time field with hours and minutes without seconds (hh:mm)?

@GSLabIt
Copy link

GSLabIt commented Apr 12, 2017

@mnatalia you need to change:

timeFormat: "hh:ii:ss",

@mnatalia
Copy link
Contributor Author

@joezsweet thank you. sorry could you try please. it doesn't change on my side.

@GSLabIt
Copy link

GSLabIt commented Apr 12, 2017

@mnatalia i can't modify core files

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants