Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar Events 'New' Button not available #3051

Closed
chdecultot opened this issue Apr 10, 2017 · 9 comments
Closed

Calendar Events 'New' Button not available #3051

chdecultot opened this issue Apr 10, 2017 · 9 comments
Assignees

Comments

@chdecultot
Copy link
Contributor

Expected Behaviour

With the right permissions, the 'New' Button should appear in the Event Calendar page.
image

Actual Behaviour

Since v8 it does not appear anymore in the calendar view. Even connected as Administrator:
image

I think it should also appear in the list view, which is not the case also:
image

Steps to reproduce:

It can be reproduced on demo.erpnext.com as well as on self hosted

  1. Go to Calendar > Event Calendar

Frappe version:
v8.0.7

@joolsr
Copy link

joolsr commented Apr 10, 2017

Yes. I have found the same situation.

@netchampfaris
Copy link
Contributor

To create a new Event, you must drag across the days in calendar and a new form will appear.

@chdecultot
Copy link
Contributor Author

Hi @netchampfaris ,

Thank you for your answer.

Drag and drop is indeed working to create an event, but in v7 there was also a 'New' Button at the top of the calendar or in the list view that is not present anymore in v8.

The main issue I have with this missing button is that the drag and drop is not working well on Android for example (Nexus 6P), and a 'New' button would be much more convenient.

Can you confirm that it is done like that by design ?

By the way, clicking on a slot doesn't work, I have to drag across two slots to create a new event. I think that is another issue also.

Thank you.

@joolsr
Copy link

joolsr commented Apr 11, 2017

i cocur with @chdecultot . Although it does work with drag and drop having a New button is more consistent with the rest of the UI. And mobile view is always a bit more demanding

@chdecultot
Copy link
Contributor Author

For information I tested again on a Nexus 6P with Android 7.1.2 and the drag and drop feature to create new events doesn't work.

Apart from the fact that it is a separate issue specific to Android, adding a New button to the calendar view would provide a handy workaround since using the calendar is one of the top feature on a smartphone.

@joolsr
Copy link

joolsr commented Apr 13, 2017

On a galaxy 5 running latest browsers ie Chrome and default one I cannot drag and drop you create an event. I agree with @chdecultot that this makes it impossible to create an event in Calendar using many normal Android phones

1 similar comment
@joolsr
Copy link

joolsr commented Apr 13, 2017

On a galaxy 5 running latest browsers ie Chrome and default one I cannot drag and drop you create an event. I agree with @chdecultot that this makes it impossible to create an event in Calendar using many normal Android phones

ashwinisave35 pushed a commit to ashwinisave35/frappe that referenced this issue May 1, 2017
nabinhait pushed a commit that referenced this issue May 2, 2017
@joolsr
Copy link

joolsr commented May 3, 2017

this has been fixed recently with this commit e5862c1

Please close - works fine now

@chdecultot
Copy link
Contributor Author

Oh yes, didn't see that! Thanks a lot! 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants