Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the in_words output only in English? Line return out + ' ' + _('only.') #8258

Open
toofun666 opened this issue Aug 25, 2019 · 5 comments

Comments

@toofun666
Copy link

return out + ' ' + _('only.')

Why is this in_words not working in Turkish language even though I have successfully implemented it num2words?

Especially this addition to the InWords considers only English.

@gavindsouza
Copy link
Collaborator

@rmehta any thoughts on this?

@madmath03
Copy link
Contributor

Maybe we could just remove the + ' ' + _('only.') ?
I do not really see a reason for this...

@gavindsouza
Copy link
Collaborator

@madmath03 This probably needs more discussion in the community; Can you create a post on discuss.erpnext.com for the same?

@madmath03
Copy link
Contributor

@madmath03 This probably needs more discussion in the community; Can you create a post on discuss.erpnext.com for the same?

@gavindsouza Sure. Discussion created : https://discuss.erpnext.com/t/why-the-only-in-the-in-words-output/61079

@nameduser0

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants