Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(doctor): update broken command behaviour #10633

Merged
merged 1 commit into from Jun 10, 2020

Conversation

gavindsouza
Copy link
Collaborator

@gavindsouza gavindsouza commented Jun 10, 2020

Bug: Change in behaviour of command
Command: bench doctor
PR: #10382
Why: Unlike other commands, doctor doesn't follow the behavioural pattern of currentsite being set. If currentsite is set and bench console, bench mariadb is run, the command will start for the current site, else you'll get a Please specify --site sitename error message. However, bench doctor does not follow this. After the aforementioned PR, this behaviour was broken. This PR reverts back to past behaviour.

Before specified PR:

-----Checking scheduler status-----
Scheduler disabled for accounting
Scheduler inactive for accounting
Scheduler disabled for bench-manager.local
Scheduler inactive for bench-manager.local
Scheduler disabled for cloud
Scheduler inactive for cloud
Scheduler disabled for erpnext_com
Scheduler inactive for erpnext_com
Scheduler disabled for erpnext_tally
Scheduler inactive for erpnext_tally
Scheduler disabled for erpnext_tally_2
Scheduler inactive for erpnext_tally_2
Scheduler disabled for frappe_io
Scheduler inactive for frappe_io
Scheduler disabled for mumbaihackathon_in
Scheduler inactive for mumbaihackathon_in
Scheduler disabled for site1.local
Scheduler inactive for site1.local
Scheduler disabled for test_site_ui
Scheduler inactive for test_site_ui
Scheduler disabled for translator
Scheduler inactive for translator
Workers online: 3
-----None Jobs-----

After specified PR:

Please specify --site sitename

After this PR:

-----Checking scheduler status-----
Scheduler disabled for accounting
Scheduler inactive for accounting
Scheduler disabled for bench-manager.local
Scheduler inactive for bench-manager.local
Scheduler disabled for cloud
Scheduler inactive for cloud
Scheduler disabled for erpnext_com
Scheduler inactive for erpnext_com
Scheduler disabled for erpnext_tally
Scheduler inactive for erpnext_tally
Scheduler disabled for erpnext_tally_2
Scheduler inactive for erpnext_tally_2
Scheduler disabled for frappe_io
Scheduler inactive for frappe_io
Scheduler disabled for mumbaihackathon_in
Scheduler inactive for mumbaihackathon_in
Scheduler disabled for site1.local
Scheduler inactive for site1.local
Scheduler disabled for test_site_ui
Scheduler inactive for test_site_ui
Scheduler disabled for translator
Scheduler inactive for translator
Workers online: 3
-----None Jobs-----

@gavindsouza
Copy link
Collaborator Author

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2020

Command backport version-12-hotfix: pending

Waiting for the pull request to get merged

@gavindsouza
Copy link
Collaborator Author

travis passed status not updated on GH, merging

@gavindsouza gavindsouza merged commit 6401bf6 into frappe:develop Jun 10, 2020
@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2020

Command backport version-12-hotfix: success

Backports have been created

gavindsouza added a commit that referenced this pull request Jun 10, 2020
…-10633

fix(doctor): update broken command behaviour (bp #10633)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants