Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dashboard fixes #11074

Merged
merged 11 commits into from Jul 27, 2020
Merged

fix: Dashboard fixes #11074

merged 11 commits into from Jul 27, 2020

Conversation

prssanna
Copy link
Contributor

@prssanna prssanna commented Jul 22, 2020

Fixes:

  • Filter out standard dashboards in Add to Dashboard dialog if developer mode is not enabled.

  • Disable dashboard form only if doc is standard and developer mode is not enabled

  • Make is_standard field read only if not in developer mode

  • Separate patch to rename is_custom to use_report_chart in Dashboard Chart

  • Remove Restricted button in Dashboard page and Dashboard View.

@prssanna prssanna requested review from sahil28297 and a team as code owners July 22, 2020 06:26
@ghost ghost removed their request for review July 22, 2020 06:26
@prssanna
Copy link
Contributor Author

@Mergifyio backport version-13-beta-pre-release

@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2020

Command backport version-13-beta-pre-release: pending

Waiting for the pull request to get merged

@prssanna prssanna merged commit 2792a1c into frappe:develop Jul 27, 2020
@prssanna prssanna deleted the dashboard-fixes branch July 27, 2020 06:56
@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2020

Command backport version-13-beta-pre-release: success

Backports have been created

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants